Skip to content

Demote missing implicit script warning #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
juliosuas wants to merge 1 commit into from
Closed

Demote missing implicit script warning #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion testing/tests/load
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@
# @TEST-EXEC: cp scripts/packages/packages.zeek after_load.out
# @TEST-EXEC: btest-diff after_load.out

# @TEST-EXEC: zkg install i-have-no-scripts
# Packages that intentionally ship only a plugin should not emit a warning
# when they omit script_dir and have no top-level __load__.zeek.
# @TEST-EXEC: zkg install i-have-no-scripts 2>install_no_scripts.err
# @TEST-EXEC: ! grep -q 'no __load__.zeek in implicit script_dir' install_no_scripts.err
# @TEST-EXEC: zkg load i-have-no-scripts
# @TEST-EXEC: cp scripts/packages/packages.zeek after_loading_no_scripts.out
# @TEST-EXEC: btest-diff after_loading_no_scripts.out
2 changes: 1 addition & 1 deletion zeekpkg/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3013,7 +3013,7 @@ def _stage(
if "script_dir" in interpolated_metadata:
return f"no __load__.zeek file found in package's 'script_dir' : {pkg_script_dir}"

LOG.warning(
LOG.debug(
'installing "%s": no __load__.zeek in implicit'
" script_dir, skipped installing scripts",
package,
Expand Down
Loading