Render leading dots for relative imports (PEP 328)#613
Open
mariopenterman wants to merge 1 commit into
Open
Conversation
Capture the IMPORT_NAME `level` operand (the number of leading dots) instead of discarding it, store it on ASTImport, and emit one `.` per level before the module name in both `from ... import ...` render paths. Restores relative imports such as `from . import x`, `from ..pkg import y`. Signed-off-by: Mario Penterman <mariopenterman@gmail.com>
mariopenterman
force-pushed
the
pr/relative-imports
branch
from
3afec9f to
f6da1e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relative imports lose their leading dots, producing invalid Python.
Before (current
master)decompiles to:
After this PR
What it does
Captures the
IMPORT_NAMEleveloperand (the number of leading dots) instead of discarding it, stores it onASTImport, and emits one.per level before the module name in bothfrom ... import ...render paths.A self-contained test is included; the full suite stays green.