Use safer clangd defaults for enrichment#227
Open
darthghandi wants to merge 6 commits into
Open
Conversation
Remove the superpowers directory and the plans and specs
zzet
reviewed
Jul 3, 2026
| // or crash-loop the enrichment subprocess. Users can opt back in via | ||
| // a semantic.providers override in .gortex.yaml. | ||
| Args: []string{ | ||
| "--background-index=false", |
Owner
There was a problem hiding this comment.
@darthghandi --background-index=false has caveats:
It can impact the C/C++ cross-file graph fidelity:
- find_usages / get_callers on a C/C++ function -> only same-TU callers; call sites in other .cpp files are not found. Ambiguous call edges never get confirmed to the lsp_resolved tier, so min_tier filtering drops them → missing caller edges.
- find_implementations -> misses implementers in other files.
- Type hierarchy -> misses subtypes defined elsewhere.
I want to benchmark it before accepting it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
semantic.providers[].args.Test Plan
GOCACHE=/tmp/gortex-go-cache GOMODCACHE=/tmp/gortex-gomod-cache go test ./internal/semantic/lsp -count=1--background-index=false --clang-tidy=false --header-insertion=never -j=1.go test ./...currently fails on both this branch and main ininternal/parser/forestdue togithub.com/alexaandru/go-sitter-forest/perlC compilation error:bsearch.h:72:7: error: expected identifier or ‘(’ before ‘_Generic’.Related: #220