[feat] Enable user MCP servers by default (http; stdio stays off-by-design) - #4912
Open
mmabrouk wants to merge 1 commit into
Open
[feat] Enable user MCP servers by default (http; stdio stays off-by-design)#4912mmabrouk wants to merge 1 commit into
mmabrouk wants to merge 1 commit into
GitHub Actions / Application SDK Unit Test Results
failed
Jul 10, 2026 in 0s
2 fail, 11 skipped, 1 763 pass in 27s
Annotations
Check warning on line 0 in oss.tests.pytest.unit.agents.test_dtos_agent_template
github-actions / Application SDK Unit Test Results
test_run_selection_unknown_permission_falls_back_to_allow_reads (oss.tests.pytest.unit.agents.test_dtos_agent_template) failed
sdks/python/oss/tests/results/junit.xml [took 0s]
Raw output
agenta.sdk.agents.dtos.InvalidPermissionDefaultError: invalid runner.permissions.default 'surprise'; expected one of ['allow', 'allow_reads', 'ask', 'deny']
def test_run_selection_unknown_permission_falls_back_to_allow_reads():
> config = AgentTemplate.from_params(
{"runner": {"permissions": {"default": "surprise"}}}
)
oss/tests/pytest/unit/agents/test_dtos_agent_template.py:264:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
agenta/sdk/agents/dtos.py:637: in from_params
harness, sandbox, permission_default = _parse_run_selection(params, base)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
params = {'runner': {'permissions': {'default': 'surprise'}}}
defaults = AgentTemplate(instructions=None, model=None, model_ref=None, tools=[], mcp_servers=[], skills=[], harness_permissions={}, harness_extras={}, sandbox_permission=None, harness='pi_core', sandbox='local', permission_default='allow_reads')
def _parse_run_selection(
params: Dict[str, Any],
defaults: AgentTemplate,
) -> Tuple[str, str, PermissionMode]:
"""Pull the execution selectors (harness kind / sandbox kind / permission default).
``harness`` from ``harness.kind``, ``sandbox`` from ``sandbox.kind``, and the runner policy
from ``runner.permissions.default``. The kinds and permission mode are lower-cased so
playground-supplied values match the bare runtime selectors."""
harness = str(_section(params, "harness").get("kind") or defaults.harness).lower()
sandbox = str(_section(params, "sandbox").get("kind") or defaults.sandbox).lower()
permissions = _section(params, "runner").get("permissions")
raw_default = permissions.get("default") if isinstance(permissions, dict) else None
if raw_default is None:
permission_default = defaults.permission_default
else:
normalized = str(raw_default).lower()
if normalized not in PERMISSION_MODES:
> raise InvalidPermissionDefaultError(normalized)
E agenta.sdk.agents.dtos.InvalidPermissionDefaultError: invalid runner.permissions.default 'surprise'; expected one of ['allow', 'allow_reads', 'ask', 'deny']
agenta/sdk/agents/dtos.py:1138: InvalidPermissionDefaultError
Check warning on line 0 in oss.tests.pytest.unit.agents.connections.test_capabilities
github-actions / Application SDK Unit Test Results
test_unknown_harness_is_permissive (oss.tests.pytest.unit.agents.connections.test_capabilities) failed
sdks/python/oss/tests/results/junit.xml [took 0s]
Raw output
AssertionError: assert False is True
+ where False = harness_allows_provider('some-future-harness', 'openai')
def test_unknown_harness_is_permissive():
> assert harness_allows_provider("some-future-harness", "openai") is True
E AssertionError: assert False is True
E + where False = harness_allows_provider('some-future-harness', 'openai')
oss/tests/pytest/unit/agents/connections/test_capabilities.py:58: AssertionError
Loading