Skip to content

[feat] Enable user MCP servers by default (http; stdio stays off-by-design) - #4912

Open
mmabrouk wants to merge 1 commit into
big-agentsfrom
feat/mcp-user-servers-default-on
Open

[feat] Enable user MCP servers by default (http; stdio stays off-by-design)#4912
mmabrouk wants to merge 1 commit into
big-agentsfrom
feat/mcp-user-servers-default-on

feat(agent): enable user MCP servers by default (http; stdio stays of…

dba14f5
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
GitHub Actions / Application API Unit Test Results failed Jul 10, 2026 in 0s

6 fail, 1 264 pass in 30s

1 270 tests  +92   1 264 ✅ +86   30s ⏱️ +4s
    1 suites ± 0       0 💤 ± 0 
    1 files   ± 0       6 ❌ + 6 

Results for commit dba14f5. ± Comparison against earlier commit 7003fe5.

Annotations

Check warning on line 0 in oss.tests.pytest.unit.secrets.test_dtos

See this annotation in the file changed.

@github-actions github-actions / Application API Unit Test Results

test_create_secret_rejects_ssrf_custom_provider_url[http://169.254.169.254/v1] (oss.tests.pytest.unit.secrets.test_dtos) failed 

api/oss/tests/results/junit.xml [took 0s]
Raw output 
Failed: DID NOT RAISE ValidationError
url = 'http://169.254.169.254/v1'

    @pytest.mark.parametrize(
        "url",
        [
            "http://169.254.169.254/v1",
            "https://127.0.0.1/v1",
            "https://10.0.0.5/v1",
            "https://192.168.1.1/v1",
            "https://localhost/v1",
            "ftp://93.184.216.34/v1",
        ],
    )
    def test_create_secret_rejects_ssrf_custom_provider_url(url):
>       with pytest.raises(ValidationError, match="custom_provider.url is invalid"):
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E       Failed: DID NOT RAISE ValidationError

oss/tests/pytest/unit/secrets/test_dtos.py:160: Failed

Check warning on line 0 in oss.tests.pytest.unit.secrets.test_dtos

See this annotation in the file changed.

@github-actions github-actions / Application API Unit Test Results

test_create_secret_rejects_ssrf_custom_provider_url[https://127.0.0.1/v1] (oss.tests.pytest.unit.secrets.test_dtos) failed 

api/oss/tests/results/junit.xml [took 0s]
Raw output 
Failed: DID NOT RAISE ValidationError
url = 'https://127.0.0.1/v1'

    @pytest.mark.parametrize(
        "url",
        [
            "http://169.254.169.254/v1",
            "https://127.0.0.1/v1",
            "https://10.0.0.5/v1",
            "https://192.168.1.1/v1",
            "https://localhost/v1",
            "ftp://93.184.216.34/v1",
        ],
    )
    def test_create_secret_rejects_ssrf_custom_provider_url(url):
>       with pytest.raises(ValidationError, match="custom_provider.url is invalid"):
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E       Failed: DID NOT RAISE ValidationError

oss/tests/pytest/unit/secrets/test_dtos.py:160: Failed

Check warning on line 0 in oss.tests.pytest.unit.secrets.test_dtos

See this annotation in the file changed.

@github-actions github-actions / Application API Unit Test Results

test_create_secret_rejects_ssrf_custom_provider_url[https://10.0.0.5/v1] (oss.tests.pytest.unit.secrets.test_dtos) failed 

api/oss/tests/results/junit.xml [took 0s]
Raw output 
Failed: DID NOT RAISE ValidationError
url = 'https://10.0.0.5/v1'

    @pytest.mark.parametrize(
        "url",
        [
            "http://169.254.169.254/v1",
            "https://127.0.0.1/v1",
            "https://10.0.0.5/v1",
            "https://192.168.1.1/v1",
            "https://localhost/v1",
            "ftp://93.184.216.34/v1",
        ],
    )
    def test_create_secret_rejects_ssrf_custom_provider_url(url):
>       with pytest.raises(ValidationError, match="custom_provider.url is invalid"):
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E       Failed: DID NOT RAISE ValidationError

oss/tests/pytest/unit/secrets/test_dtos.py:160: Failed

Check warning on line 0 in oss.tests.pytest.unit.secrets.test_dtos

See this annotation in the file changed.

@github-actions github-actions / Application API Unit Test Results

test_create_secret_rejects_ssrf_custom_provider_url[https://192.168.1.1/v1] (oss.tests.pytest.unit.secrets.test_dtos) failed 

api/oss/tests/results/junit.xml [took 0s]
Raw output 
Failed: DID NOT RAISE ValidationError
url = 'https://192.168.1.1/v1'

    @pytest.mark.parametrize(
        "url",
        [
            "http://169.254.169.254/v1",
            "https://127.0.0.1/v1",
            "https://10.0.0.5/v1",
            "https://192.168.1.1/v1",
            "https://localhost/v1",
            "ftp://93.184.216.34/v1",
        ],
    )
    def test_create_secret_rejects_ssrf_custom_provider_url(url):
>       with pytest.raises(ValidationError, match="custom_provider.url is invalid"):
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E       Failed: DID NOT RAISE ValidationError

oss/tests/pytest/unit/secrets/test_dtos.py:160: Failed

Check warning on line 0 in oss.tests.pytest.unit.secrets.test_dtos

See this annotation in the file changed.

@github-actions github-actions / Application API Unit Test Results

test_create_secret_rejects_ssrf_custom_provider_url[https://localhost/v1] (oss.tests.pytest.unit.secrets.test_dtos) failed 

api/oss/tests/results/junit.xml [took 0s]
Raw output 
Failed: DID NOT RAISE ValidationError
url = 'https://localhost/v1'

    @pytest.mark.parametrize(
        "url",
        [
            "http://169.254.169.254/v1",
            "https://127.0.0.1/v1",
            "https://10.0.0.5/v1",
            "https://192.168.1.1/v1",
            "https://localhost/v1",
            "ftp://93.184.216.34/v1",
        ],
    )
    def test_create_secret_rejects_ssrf_custom_provider_url(url):
>       with pytest.raises(ValidationError, match="custom_provider.url is invalid"):
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E       Failed: DID NOT RAISE ValidationError

oss/tests/pytest/unit/secrets/test_dtos.py:160: Failed

Check warning on line 0 in oss.tests.pytest.unit.secrets.test_dtos

See this annotation in the file changed.

@github-actions github-actions / Application API Unit Test Results

test_update_secret_rejects_ssrf_custom_provider_url (oss.tests.pytest.unit.secrets.test_dtos) failed 

api/oss/tests/results/junit.xml [took 0s]
Raw output 
Failed: DID NOT RAISE ValidationError
def test_update_secret_rejects_ssrf_custom_provider_url():
        payload = {
            "secret": {
                "kind": "custom_provider",
                "data": {
                    "kind": "custom",
                    "provider": {"url": "http://10.0.0.5/v1", "key": "sk-gw"},
                    "models": [{"slug": "gpt-4o-mini"}],
                },
            },
        }
>       with pytest.raises(ValidationError, match="custom_provider.url is invalid"):
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E       Failed: DID NOT RAISE ValidationError

oss/tests/pytest/unit/secrets/test_dtos.py:188: Failed
View more details on GitHub Actions