Skip to content

chore(oss): retire deprecated Electron shell and organize legacy docs - #1133

Merged
PurpleCHOIms merged 5 commits into
mainfrom
chore/oss-retire-legacy-layout-20261027
Oct 27, 2026
Merged

PurpleCHOIms merged 5 commits into
mainfrom
chore/oss-retire-legacy-layout-20261027

Conversation

@PurpleCHOIms

Copy link
Copy Markdown
Member

Retire the already-deprecated Electron shell and remove obsolete repository entry points so the supported launcher, terminal, web dashboard and benchmark adapter are clear. Archive the completed Phase 0 cleanup notes and add a documentation/repository index instead of presenting old plans as current contribution procedures.

Changes and compatibility

  • Delete clients/desktop/, the two npm desktop commands, 10 obsolete lockfile records, the Electron CI matrix, its path filter and its aggregator dependency. Use decepticon start and /web. The Go launcher's host Desktop integration remains supported.
  • Remove the root decepticon_tbench_agent.py compatibility shim. Make and the full-run script already use benchmark.terminal_bench:DecepticonTerminalBenchAgent; saved external Harbor configs must migrate to that path.
  • Preserve completed skill migration history under docs/archive/skill-cleanup/; repair maintained links and contributor paths, and add docs/README.md with current guides and historical categories. Preserve ADRs, security and release evidence.
  • Record proposed behavior and migration notes in CHAGELOG.md and verification evidence.

Intent and review

Requested OSS repository cleanup; external CLI skill restructuring is separately reviewed in #1132. Both branches start at the freshly fetched remote main 96b70861. No release or deployment is requested.

Why this touches a supply-chain surface

The removed npm workspace must also be removed from root scripts/lockfile and CI; retaining any of those references would install obsolete Electron dependencies or leave failing checks. Retained package versions and records are byte-equivalent after JSON parsing. Tier-supply-chain: review required before merge. Only retirement-related packaging/CI surfaces and repository guidance are changed.

Diff budget

Requesting large-diff-approved from @PurpleCHOIms: deleting the deprecated package necessarily removes roughly 1,700 lines across its existing files; the runtime diff adds no replacement implementation. Splitting deletion of its modules would leave a broken package between PRs. Documentation is excluded from the runtime budget. Do not merge until the requested exception/review is accepted.

End-to-end verification

npm ci --ignore-scripts --offline --no-audit --no-fund installed 1,045 packages without Electron; npm ls --workspaces --depth=0 --omit=dev resolved retained workspaces and exited 0. A parsed lockfile comparison found exactly 10 removed entries, zero new entries and no changed retained package records. Shared streaming build and CLI typecheck passed. CLI tests passed all 300 tests across 41 files with --maxWorkers=4; the first unrestricted run passed 299 and hit a 5-second timeout in scoped HTTP diagnostics, recorded in the evidence rather than hidden. No timeout or test code was changed. The canonical Terminal-Bench adapter suite passed all 10 tests. Workflow actionlint validation, job dependency validation, relative links and git diff --check passed.

Lifecycle scripts, full production builds, make quality/make smoke, live security engagements and web browser QA were not run for this removal/documentation change. Retained web source is unchanged. Private/local state was not migrated or deleted. See the evidence for exact commands and limits.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T14:34:54.382591Z 921eff6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@PurpleCHOIms PurpleCHOIms added the large-diff-approved Maintainer-approved exception to contribution diff limits label Oct 27, 2026 — with ChatGPT Codex Connector
@PurpleCHOIms
PurpleCHOIms merged commit 3fed017 into main Oct 27, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

large-diff-approved Maintainer-approved exception to contribution diff limits

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant