Repository navigation
chore(oss): retire deprecated Electron shell and organize legacy docs - #1133
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
1 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retire the already-deprecated Electron shell and remove obsolete repository entry points so the supported launcher, terminal, web dashboard and benchmark adapter are clear. Archive the completed Phase 0 cleanup notes and add a documentation/repository index instead of presenting old plans as current contribution procedures.
Changes and compatibility
clients/desktop/, the two npm desktop commands, 10 obsolete lockfile records, the Electron CI matrix, its path filter and its aggregator dependency. Usedecepticon startand/web. The Go launcher's host Desktop integration remains supported.decepticon_tbench_agent.pycompatibility shim. Make and the full-run script already usebenchmark.terminal_bench:DecepticonTerminalBenchAgent; saved external Harbor configs must migrate to that path.docs/archive/skill-cleanup/; repair maintained links and contributor paths, and adddocs/README.mdwith current guides and historical categories. Preserve ADRs, security and release evidence.Intent and review
Requested OSS repository cleanup; external CLI skill restructuring is separately reviewed in #1132. Both branches start at the freshly fetched remote main
96b70861. No release or deployment is requested.Why this touches a supply-chain surface
The removed npm workspace must also be removed from root scripts/lockfile and CI; retaining any of those references would install obsolete Electron dependencies or leave failing checks. Retained package versions and records are byte-equivalent after JSON parsing. Tier-supply-chain: review required before merge. Only retirement-related packaging/CI surfaces and repository guidance are changed.
Diff budget
Requesting
large-diff-approvedfrom @PurpleCHOIms: deleting the deprecated package necessarily removes roughly 1,700 lines across its existing files; the runtime diff adds no replacement implementation. Splitting deletion of its modules would leave a broken package between PRs. Documentation is excluded from the runtime budget. Do not merge until the requested exception/review is accepted.End-to-end verification
npm ci --ignore-scripts --offline --no-audit --no-fundinstalled 1,045 packages without Electron;npm ls --workspaces --depth=0 --omit=devresolved retained workspaces and exited 0. A parsed lockfile comparison found exactly 10 removed entries, zero new entries and no changed retained package records. Shared streaming build and CLI typecheck passed. CLI tests passed all 300 tests across 41 files with--maxWorkers=4; the first unrestricted run passed 299 and hit a 5-second timeout in scoped HTTP diagnostics, recorded in the evidence rather than hidden. No timeout or test code was changed. The canonical Terminal-Bench adapter suite passed all 10 tests. Workflow actionlint validation, job dependency validation, relative links andgit diff --checkpassed.Lifecycle scripts, full production builds,
make quality/make smoke, live security engagements and web browser QA were not run for this removal/documentation change. Retained web source is unchanged. Private/local state was not migrated or deleted. See the evidence for exact commands and limits.