Repository navigation
test(backends): prevent capture timeout fixture from starting live tmux - #1142
Merged
Merged
Conversation
PurpleCHOIms
marked this pull request as ready for review
November 1, 2026 17:17
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The capture-timeout unit test used a stale cache key and could initialize real local tmux before reaching its mocked timeout. Stub initialization and assert no tmux command occurs; preserve timeout/error behavior assertions and runtime source.
Local verification: 26 affected tests, Ruff check/format and basedpyright errors-only pass. Full fast Python suite through the shared coordinator: 6,133 passed, 3 Windows-only skips, 15 existing warnings, exit 0 in 197.72 seconds. No live fixture tmux session remains. Existing CLI/Web/runtime inputs are unchanged from qualified #1141; no new product build is needed for this test-only correction. Actual hosted checks run and remain subject to normal repository protection.
Evidence and limitations · CHAGELOG.md. Follow-up to #1141. No release, tag or SaaS production change.