Skip to content

docs(sdk): document programs, verbosity and utilities in rustdoc - #194

Merged
Arvolear merged 1 commit into
BlockstreamResearch:devfrom
schoen:docs/rustdoc-program
Nov 5, 2026
Merged

Arvolear merged 1 commit into
BlockstreamResearch:devfrom
schoen:docs/rustdoc-program

Conversation

@schoen

@schoen schoen commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Describe how a Program compiles and caches, which settings determine its CMR and its address, the shape of its Taproot tree with storage, which getters panic on a compile error, and what execute and finalize check and return.

Correct three doc comments: ScriptPubkeyMismatch holds HASH160 script hashes, not CMRs; Program reports Bit Machine failures as Pruning and never returns ProgramError::Execution; and which signer methods print execution output, and when.

Also document the verbosity's effect on addresses, the utilities that compute hashes and entropy, and what DUMMY_SIGNATURE and MIN_FEE are for.

  • This PR suggests a bug fix and I've added the necessary tests.
  • This PR introduces a new feature and I've discussed the update in an Issue or with the team.
  • This PR is just a minor change like a typo fix.

@schoen
schoen requested a review from Arvolear as a code owner October 29, 2026 00:10
@Arvolear
Arvolear deleted the branch BlockstreamResearch:dev October 30, 2026 16:28
@Arvolear Arvolear closed this Oct 30, 2026
@Arvolear Arvolear reopened this Oct 30, 2026
@schoen
schoen force-pushed the docs/rustdoc-program branch from d5264dc to f99287e Compare November 2, 2026 21:57
Describe how a `Program` compiles and caches, which settings determine
its CMR and its address, the shape of its Taproot tree with storage,
which getters panic on a compile error, and what `execute` and
`finalize` check and return.

Correct three doc comments: `ScriptPubkeyMismatch` holds HASH160 script
hashes, not CMRs; `Program` reports Bit Machine failures as `Pruning` and
never returns `ProgramError::Execution`; and which signer methods print
execution output, and when.

Also document the verbosity's effect on addresses, the utilities that
compute hashes and entropy, and what `DUMMY_SIGNATURE` and `MIN_FEE`
are for.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@Arvolear Arvolear left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Arvolear
Arvolear merged commit 9ed4641 into BlockstreamResearch:dev Nov 5, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants