Detect AutoIt source content - #76
Closed
adepasquale wants to merge 1 commit into
Closed
Conversation
AutoIt v3 source/decompiled scripts submitted without an extension were falling through to the generic fallback, since ident.py had no content-based AutoIt sniffer alongside the existing ones for PowerShell, VBScript, JS, and Node.js. A recognized extension still resolves via the existing extension-based shortcut, which this change does not touch. Add an autoit() identifier to the identifiers list, following the same category/minimum-hit-count pattern as nodejs(): three independent signal categories (Func-block syntax, AutoIt-only builtins, "@Identifier" macro syntax), each collapsed into a single compiled alternation regex with word boundaries. Requiring hits in at least two categories avoids false positives from keywords AutoIt shares with VBScript (Dim, If, Else, ...), and word boundaries avoid substring collisions like "EndFunc" inside "appendFunction" or "SetError" inside "resetError".
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Collaborator
|
thank you will review tomorrow, autoit3 has very good header detection generally, but all detection is good! |
Collaborator
|
Superseded by #80 which incorporates these great changes and adds the checks along with bounding 2MB parsing slices. |
Collaborator
|
i had to close it as im not allowed to edit this PR, but i got your changes to #80 . thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoIt v3 source/decompiled scripts submitted without an extension were falling through to the generic fallback, since ident.py had no content-based AutoIt sniffer alongside the existing ones for PowerShell, VBScript, JS, and Node.js. A recognized extension still resolves via the existing extension-based shortcut, which this change does not touch.
Add an autoit() identifier to the identifiers list, following the same category/minimum-hit-count pattern as nodejs(): three independent signal categories (Func-block syntax, AutoIt-only builtins, "@Identifier" macro syntax), each collapsed into a single compiled alternation regex with word boundaries. Requiring hits in at least two categories avoids false positives from keywords AutoIt shares with VBScript (Dim, If, Else, ...), and word boundaries avoid substring collisions like "EndFunc" inside "appendFunction" or "SetError" inside "resetError".