Add compiled script signature checks to AutoIt Detection - #80
Merged
Conversation
AutoIt v3 source/decompiled scripts submitted without an extension were falling through to the generic fallback, since ident.py had no content-based AutoIt sniffer alongside the existing ones for PowerShell, VBScript, JS, and Node.js. A recognized extension still resolves via the existing extension-based shortcut, which this change does not touch. Add an autoit() identifier to the identifiers list, following the same category/minimum-hit-count pattern as nodejs(): three independent signal categories (Func-block syntax, AutoIt-only builtins, "@Identifier" macro syntax), each collapsed into a single compiled alternation regex with word boundaries. Requiring hits in at least two categories avoids false positives from keywords AutoIt shares with VBScript (Dim, If, Else, ...), and word boundaries avoid substring collisions like "EndFunc" inside "appendFunction" or "SetError" inside "resetError".
…rch to 1MB and regex search to 128KB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supersedes #76 and adds compiled script
AU3!EA06signature checking, limited to the first 2MB. Also includes the robust Regex source-code checking from adepasquale, capped to 2MB to prevent ReDoS on massive bloated files.