Repository navigation
feat(kalico): support the multiple-probe registry - #525
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason / issue reference
KalicoCrew/kalico#972 moves native probe discovery to a central registry. Cartographer must join that registry to remain discoverable and coexist with other probes.
Functional changes
cartographeron registry-capable Kalico:register_as_probe: truemakes it default;falsemakes it named-only.PROBE,PROBE_ACCURACY,QUERY_PROBE, andZ_OFFSET_APPLY_PROBE, preserving other probes' handlers.Decisions and callouts
CALIBRATE_Z,PROBE_Z_ACCURACY, and nozzle cleanup cannot use Cartographer; unsupported uses fail explicitly before motion. StockPROBE_CALIBRATEis not implemented; use Cartographer's calibration commands.Manual testing
LIST_PROBESmarks Cartographer as default and bareQUERY_PROBEtargets it.QUERY_PROBE PROBE=cartographerand bareQUERY_PROBEtarget the intended devices.METHOD=scanwith another probe fail without movement.Install
To revert to the latest stable release:
~/klippy-env/bin/pip install --no-cache-dir --force-reinstall cartographer3d-plugin sudo systemctl restart klipper