-
Notifications
You must be signed in to change notification settings - Fork 4
Remove outdated information #5218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 2 commits
0636a01
f94ccb2
5acbdc8
434aa96
720a461
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,5 +11,4 @@ cg.egg-info | |
| .gitlint.yaml | ||
| .pre-commit-config.yaml | ||
| DEPLOYMENT.md | ||
| CONTRIBUTING.md | ||
| Dockerfile | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,41 +11,3 @@ | |
| ### Fixed | ||
|
|
||
| - | ||
|
|
||
|
|
||
| ### How to prepare for test | ||
|
|
||
| - [ ] Ssh to relevant server (depending on type of change) | ||
| - [ ] Use stage: `us` | ||
| - [ ] Paxa the environment: `paxa` | ||
| - [ ] Install on stage (example for Hasta): | ||
| ```shell | ||
| bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a | ||
| ``` | ||
|
Comment on lines
-22
to
-24
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I use this shortcut very often; it would be great to keep it somehow. Maybe the rest of the items in this section can go. |
||
|
|
||
| ### How to test | ||
|
|
||
| - [ ] Do ... | ||
|
|
||
| ### Expected test outcome | ||
|
|
||
| - [ ] Check that ... | ||
| - [ ] Take a screenshot and attach or copy/paste the output. | ||
|
Comment on lines
-26
to
-33
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm ok with removing this. Maybe we could add a section reminding us to paste test results in the comments, hiding sensitive information, but if you find it superfluous, let's just remove it |
||
|
|
||
| ## Review | ||
|
|
||
| - [ ] Tests executed by | ||
| - [ ] "Merge and deploy" approved by | ||
| Thanks for filling in who performed the code review and the test! | ||
|
|
||
| ### This [version](https://semver.org/) is a | ||
|
|
||
| - [ ] **MAJOR** - when you make incompatible API changes | ||
| - [ ] **MINOR** - when you add functionality in a backwards compatible manner | ||
| - [ ] **PATCH** - when you make backwards compatible bug fixes or documentation/instructions | ||
|
|
||
| ## Implementation Plan | ||
|
|
||
| - [ ] Document in ... | ||
| - [ ] Deploy this branch on ... | ||
| - [ ] Inform to ... | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@diitaz93 What do you think of this change? Do you thing the other headings except Description and added/changed/fixed are useful?