Skip to content

Add a named qr_compact! wrapping TensorAlgebra.qr_compact! - #275

Open
jack-dunham wants to merge 1 commit into
mainfrom
qr-compact-inplace
Open

jack-dunham wants to merge 1 commit into
mainfrom
qr-compact-inplace

Conversation

@jack-dunham

Copy link
Copy Markdown
Contributor

Adds MatrixAlgebraKit.qr_compact! methods for AbstractNamedTensor. They mirror the
existing named qr_compact, including the name keyword for the new bond, and call
TensorAlgebra.qr_compact!, so a dense input's memory is reused for Q.

Requires ITensor/TensorAlgebra.jl#243

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.36%. Comparing base (882e825) to head (ae5731c).

Files with missing lines Patch % Lines
src/tensoralgebra.jl 0.00% 9 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (882e825) and HEAD (ae5731c). Click for more details.

HEAD has 13 uploads less than BASE
Flag BASE (882e825) HEAD (ae5731c)
12 0
docs 2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #275       +/-   ##
===========================================
- Coverage   82.36%   32.36%   -50.00%     
===========================================
  Files          21       20        -1     
  Lines        1474     1443       -31     
===========================================
- Hits         1214      467      -747     
- Misses        260      976      +716     
Flag Coverage Δ
docs 32.36% <0.00%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant