Skip to content

Add a named qr_compact! wrapping TensorAlgebra.qr_compact! #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jack-dunham wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add a named qr_compact! wrapping TensorAlgebra.qr_compact! #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/tensoralgebra.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,23 @@ for f in [
end
end

function MAK.qr_compact!(
a::AbstractNamedTensor, names_codomain, names_domain; name = (;), kwargs...
)
# `name` is a keyword here, so reach the `name` function through the module.
codomain = ITensorBase.name.(names_codomain)
domain = ITensorBase.name.(names_domain)
q_unnamed, r_unnamed =
TA.qr_compact!(unnamed(a), names(a), codomain, domain; kwargs...)
bond = to_uniquename_function(name)(nametype(a))
return NamedTensor(q_unnamed, (codomain..., bond)),
NamedTensor(r_unnamed, (bond, domain...))
end
function MAK.qr_compact!(a::AbstractNamedTensor, names_codomain; kwargs...)
codomain = name.(names_codomain)
return MAK.qr_compact!(a, codomain, names_setdiff(names(a), codomain); kwargs...)
end

#
# SVD (three-output).
#
Expand Down
9 changes: 8 additions & 1 deletion test/test_tensoralgebra.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ using ITensorBase: ITensorBase, Index, NamedOneTo, id, inds, mulopadd!, name, op
prime, rename, unname, unnamed
using LinearAlgebra: mul!, norm, tr
using MatrixAlgebraKit: left_null, left_orth, left_polar, lq_compact, lq_full, qr_compact,
qr_full, right_null, right_orth, right_polar, svd_compact, svd_trunc, svd_vals
qr_compact!, qr_full, right_null, right_orth, right_polar, svd_compact, svd_trunc,
svd_vals
using StableRNGs: StableRNG
using TensorAlgebra: TensorAlgebra, contract, directsum, matricize, project, trivialrange,
unchecked_project, unmatricize
Expand Down Expand Up @@ -121,6 +122,12 @@ using Test: @test, @test_broken, @testset
x, y = f(a, (i, k), (j, l))
@test x * y ≈ a
end

q, r = qr_compact(a, (i, k), (j, l))
q′, r′ = qr_compact!(copy(a), (i, k), (j, l); name = Returns(names(r, 1)))
@test q′ ≈ q && r′ ≈ r
q′, r′ = qr_compact!(copy(a), (i, k))
@test q′ * r′ ≈ a
end
@testset "svd" begin
dims = (2, 2, 2, 2)
Expand Down
Loading