Repository navigation
probe: Resolve externally registered default probe - #1014
Merged
Merged
Conversation
rogerlz
force-pushed
the
fix-probe-external-default
branch
from
October 12, 2026 10:55
dd0d473 to
fa08eb2
Compare
Third-party probes such as Beacon register "probe" directly without going through ProbeList. Since #972 this made ProbePointsHelper users (Z_TILT_ADJUST, QUAD_GANTRY_LEVEL, ...) fall into manual probing. Always create ProbeList before loading config sections, and fill default_probe from the "probe" object on connect if none registered. Signed-off-by: Rogerio Goncalves <rogerlz@gmail.com>
rogerlz
force-pushed
the
fix-probe-external-default
branch
from
October 12, 2026 16:06
fa08eb2 to
1d1a3d2
Compare
rogerlz
changed the title
dalegaard
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
probedirectly (Beacon, Cartographer) are not found byProbeList, soZ_TILT_ADJUST,QUAD_GANTRY_LEVELand otherProbePointsHelperusers fall into manual probingProbeListis now always created before config sections load, and fillsdefault_probefrom theprobeobject on connectTest plan
proberegistered after it resolves the default on connect