Repository navigation
Conversation
1 task done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Extend the immersive media regression fixture with desktop and narrow-touch scenarios for image and video rotation.
Validation
Companion
c756a58against client98201d9dpassed all 10 Node cases and all four Chromium viewports. The new browser regression fails on client baseline5ab3994dbecause the Rotate button is missing.Dependencies
9735a655bf4e1fe6b65348cb37ee08e0fb6a0989for its immersive viewer fixture and offline runner.mainusing the recorded parent tip as the rebase boundary and retarget this PR. Rerun the focused suites against clientmainafter the rotation change lands and record the tested SHA before merging these tests.