Skip to content

Cover rotation in the immersive media viewer - #137

Draft
dnlbui wants to merge 1 commit into
codex/1858-immersive-media-testsfrom
codex/1867-media-rotation-tests
Draft

dnlbui wants to merge 1 commit into
codex/1858-immersive-media-testsfrom
codex/1867-media-rotation-tests

Conversation

@dnlbui

@dnlbui dnlbui commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

What Changed

Extend the immersive media regression fixture with desktop and narrow-touch scenarios for image and video rotation.

  • Check keyboard access, filename layout, idle hide and reveal, centered fit, image zoom and pan, and reset on close or replacement.
  • Use the rotated video’s native Play and seek controls and verify playback position and state across turns.

Validation

Companion c756a58 against client 98201d9d passed all 10 Node cases and all four Chromium viewports. The new browser regression fails on client baseline 5ab3994d because the Rotate button is missing.

WEB_CLIENT_ROOT=/home/bui/.codex/worktrees/9aaa/web-client-v2 \
PLAYWRIGHT_ROOT=/home/bui/shared/liberdus/client-testing/playwright-tests \
MEDIA_PREVIEW_BROWSER=/opt/google/chrome/chrome \
node local-tests/run.mjs issue-1858-immersive-media.test.mjs \
  issue-1858-immersive-media.browser.test.mjs

Dependencies

  • Covers web-client #1867 via client draft PR #1873.
  • Stacked on companion #124 at 9735a655bf4e1fe6b65348cb37ee08e0fb6a0989 for its immersive viewer fixture and offline runner.
  • After the parent merges, replay this layer onto companion main using the recorded parent tip as the rebase boundary and retarget this PR. Rerun the focused suites against client main after the rotation change lands and record the tested SHA before merging these tests.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant