Repository navigation
Add rotation to image and video previews - #1873
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Add a keyboard-accessible Rotate clockwise button opposite Back in the image and video viewer. It follows the existing header hide and reveal behavior and leaves room for the filename.
Fixed Flow
Demo
Recorded in the mobile viewer with synthetic media.
issue-1867-media-viewer-rotation.mp4
Why
The viewer previously had no way to correct an attachment's viewing orientation without leaving the preview.
Validation
Client
98201d9dwith companionc756a58passed all 10 immersive Node cases and four Chromium viewports. The new browser check fails on client baseline5ab3994dbecause the Rotate button is missing. A narrow Firefox smoke test passed, including native fullscreen. WebKit could not launch on this host becauselibwoff1andlibavif16are missing.node --check app.js git diff origin/main...HEAD --check # From the companion test worktree WEB_CLIENT_ROOT=/home/bui/.codex/worktrees/9aaa/web-client-v2 \ PLAYWRIGHT_ROOT=/home/bui/shared/liberdus/client-testing/playwright-tests \ MEDIA_PREVIEW_BROWSER=/opt/google/chrome/chrome \ node local-tests/run.mjs issue-1858-immersive-media.test.mjs \ issue-1858-immersive-media.browser.test.mjsThe adjacent attachment cache ID suite passed. The older
issue-1656-full-image-cache,issue-1847-video-preview, andf02-attachment-securitysuites reproduced the same failures on the baseline and patched revisions.Companion regression tests
local-tests/tests/issue-1858-immersive-media*.test.mjsfiles are oncodex/1867-media-rotation-testsatc756a58. See validation above for the tested client revision and results.main. Rerun the focused tests against clientmainonce the rotation change lands, then record the tested SHA before merging the companion PR.Related Issues
Closes #1867