chore: resolve TODO on .so file size in scanDeployDirectory#62
Open
Leomrqdd wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
I was exploring the gimlet VScode plugin and wanted to help on a simple TO-DO I saw in the source code, it's not much but it could maybe help :
Issue :
Resolves the
TODO(lime): any chance of too big .so files?inscanDeployDirectory.Answer:
-Deployed Solana programs are bounded by
MAX_PERMITTED_DATA_LENGTH= 10 MB (program account data cap), so a local.sohas no reason to exceed it.-Measured
readFileSync+ SHA-256 at the theoretical worst case (10 MB): ~8 ms on my macbook pro M2.So I don't think there is any chance of too big .so files. Even Jupiter V6 program is like 2.9 MB (.so).
Best,
Léo