Skip to content

chore: resolve TODO on .so file size in scanDeployDirectory #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Leomrqdd wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: resolve TODO on .so file size in scanDeployDirectory #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/extension.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,10 @@ async function scanDeployDirectory(session) {
soCount++;

const soPath = path.join(artifactsPath, file);
const hash = crypto.createHash('sha256').update(fs.readFileSync(soPath)).digest('hex'); // TODO(lime): any chance of too big .so files?
// Sync read+hash is fine here: deployed programs are bounded by the
// 10 MiB account data cap (MAX_PERMITTED_DATA_LENGTH), so worst case
// stays in the single-digit ms range.
const hash = crypto.createHash('sha256').update(fs.readFileSync(soPath)).digest('hex');
session.setProgramNameForHash(hash, file);

session.executablesPaths[file] = {
Expand Down