call gc_collect_cycles() for every message#2168
Merged
Merged
Conversation
| */ | ||
| public function workWrapper(MessageInterface $message): void | ||
| { | ||
| gc_collect_cycles(); |
Member
There was a problem hiding this comment.
wouldn't this make more sense to be called at the end? So after a message has been processed
Collaborator
Author
There was a problem hiding this comment.
It would.
But if something goes very wrong, it might not reach this statement. As there are almost always new messages it should not make much of a difference.
Contributor
There was a problem hiding this comment.
That's the use case for finally ;)
BentiGorlich
approved these changes
Jul 19, 2026
blued-gear
enabled auto-merge (squash)
July 19, 2026 10:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This might help keeping the memory-consumption of the messengers low. It might also not help, but the worst it can do is add a few milliseconds of delay to the processing of every message.
As far as I checked it helped on some message type and on others it did not lower the overall memory consumption. If this is worth merging is up to you.