Skip to content

call gc_collect_cycles() for every message #2168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blued-gear merged 4 commits into from
Jul 19, 2026
Merged

call gc_collect_cycles() for every message #2168

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
23b7001
call gc_collect_cycles() for every message
blued-gear Jul 17, 2026
93cf34d
do gc_collect_cycles() at the end
blued-gear Jul 19, 2026
73fbccb
linter
blued-gear Jul 19, 2026
2d44c82
add more excluded directories for linter (to keep it from failing loc…
blued-gear Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/MessageHandler/MbinMessageHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ public function __construct(
*/
public function workWrapper(MessageInterface $message): void
{
gc_collect_cycles();

@BentiGorlich BentiGorlich Jul 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't this make more sense to be called at the end? So after a message has been processed

@blued-gear blued-gear Jul 18, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would.
But if something goes very wrong, it might not reach this statement. As there are almost always new messages it should not make much of a difference.

@garrettw garrettw Jul 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the use case for finally ;)


// when we are in the test environment this would throw: ConnectionException: There is no active transaction.
if ('test' !== $this->kernel->getEnvironment()) {
$conn = $this->entityManager->getConnection();
Expand Down
Loading