[build] fix: restore ModelOpt-compatible TransformerEngine revision#4615
Closed
yaoyu-33 wants to merge 2 commits into
Closed
[build] fix: restore ModelOpt-compatible TransformerEngine revision#4615yaoyu-33 wants to merge 2 commits into
yaoyu-33 wants to merge 2 commits into
Conversation
…-07-01) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Yu Yao <yaoyu.094@gmail.com>
Contributor
Author
|
/ok to test 7ea9c2f |
Contributor
|
LGTM — clean, surgical dependency fix. The PR correctly reverts the TE override to the ModelOpt-compatible revision ( The Suggested test cases: No perf tests impacted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirrors the automated release bump from #4613 and restores the TransformerEngine override to the ModelOpt-compatible
d64bc14dc87eb658ab98839e4b7687595ee53e2drevision.release-r0.5.0(base branchr0.5.0)Root cause
On 2026-06-26, release PR #4535 updated the Bridge override to TransformerEngine
b9d690e0while retainingnvidia-modelopt==0.44.0rc5. TransformerEngine now passesm_splitsas an explicit grouped-linear argument, but that ModelOpt release still reads the firstnon_tensor_argsitem as the split sequence and raisesTypeError: object of type 'bool' has no len().The 2026-07-01 automated MCore bump #4613 exposes the already-present incompatibility in both H100 and GB200 Qwen3 MoE quantization jobs.
Fix
d64bc14dc87eb658ab98839e4b7687595ee53e2d, before the incompatible grouped-linear argument change.uv.lock.uv.lock(r0.5.0, mcore-core_r0.18.0) (2026-07-01) #4613's exact458c8d0ecafdf6d9e36771600d62ade27f2a67b7commit.This is the release-line counterpart of #4600, whose H100 and GB200 Qwen quantization jobs both pass with the same TransformerEngine revision.
Validation
uv run pre-commit run --all-files— passed on 2026-07-01.interactivejob13313466on 2026-07-01:uv lock --check— passed (344 packages).NVTE_CUDA_ARCHS=90 uv sync --locked --group dev --group test --extra te— passed and installed TransformerEngine2.16.0+d64bc14d.uv run --no-sync python -m pytest tests/unit_tests/models/gpt/test_gpt_builder.py tests/unit_tests/models/test_gpt_provider.py -v— 81 passed.(ctx, inp, non_tensor_args, *weights_and_biases).