Add advisory audit for NVIDIA API deprecations [reduced-it] - #15867
Add advisory audit for NVIDIA API deprecations [reduced-it]#15867gerashegalov wants to merge 7 commits into
Conversation
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
Greptile SummaryThis PR makes deprecations from selected NVIDIA-owned APIs advisory while preserving fatal treatment for third-party deprecations, and adds an optional GitHub Actions audit that collects diagnostics from completed matrix jobs.
Confidence Score: 4/5The implementation appears technically sound, but the explicit performance-checklist requirement must be satisfied before merging. The audit and compiler-policy changes have focused validation, and the recent removal of the hybrid property leaves no dangling references. Merge readiness is blocked only by the missing verifiable rationale for marking performance testing as unnecessary. Files Needing Attention: .github/workflows/mvn-verify-check.yml Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
Matrix[Maven matrix jobs] --> Logs[Completed job logs]
Logs --> Audit[Jython deprecation audit]
Audit --> Parse[Parse and deduplicate diagnostics]
Parse --> Summary[GitHub job summary and annotations]
Parse --> Artifact[Raw JSON report]
Parse --> Result{Findings or incomplete collection?}
Result -- Yes --> Fail[Fail optional audit]
Result -- No --> Pass[Pass audit]
Reviews (7): Last reviewed commit: "Merge branch 'main' into codex/nvidia-de..." | Re-trigger Greptile |
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
|
build |
|
build |
|
build |
Related to #15825.
Description
Deprecation annotations in NVIDIA-owned dependencies can land before cudf-spark can consume an
artifact containing the replacement API. With fatal Scala warnings, that ordering breaks unrelated
cudf-spark pull requests even though no compatible migration is available yet.
This change keeps deprecations from NVIDIA-owned cuDF Java, cudf-spark-jni, and
cudf-spark-private APIs visible as compiler information while retaining fatal handling for
third-party deprecations. Because cudf-spark-private does not have one artifact-specific namespace,
the policy covers its NVIDIA-owned package roots and an exact
PartialAggUtilsbridge symbol; anadjacent Spark symbol remains fatal as a regression control.
The Maven pull-request workflow also gains an optional fan-in audit that downloads completed
matrix-job logs and reports compiler deprecations in the job summary and annotations. Findings or
incomplete log collection fail this optional check so contributors inspect it, while the report is
still uploaded and the build jobs remain authoritative. Log collection validates GitHub signed
redirects and never forwards the repository token to the signed download URL. Contributor
documentation now describes the staged cross-repository deprecation lifecycle. Both the compiler-
policy fixture checker and log audit run through Maven's existing Jython 2.7.3 dependency, so this
change does not add a host Python prerequisite; the existing resource-nesting check remains on
Python 3 for a dedicated follow-up port.
Validation performed:
mvn -N -Dbuildver=330 verifymvn -N -f scala2.13/pom.xml -Dbuildver=350 verifygit diff --checkChecklists
Documentation
Testing
(Please provide the names of the existing tests in the PR description.)
Performance