Skip to content

chore(i18n): sync Turkish with V2 migration key changes - #685

Merged
pascalandr merged 4 commits into
NeuralNomadsAI:devfrom
fitzgpt:chore/i18n-tr-v2-sync
Sep 9, 2026
Merged

chore(i18n): sync Turkish with V2 migration key changes#685
pascalandr merged 4 commits into
NeuralNomadsAI:devfrom
fitzgpt:chore/i18n-tr-v2-sync

Conversation

@fitzgpt

@fitzgpt fitzgpt commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #662 (Turkish localization). The native V2 migration (#647) and the follow-up commits (#672, #682) changed the i18n key set without updating tr/, so the Turkish UI currently renders 76 English strings and carries 35 stale keys.

This PR brings tr/ back to 1:1 key parity with en/ (1721 = 1721 leaves, verified programmatically):

Added (76 keys) across 5 files:

  • instance.ts — background shell statuses (running/exited/timeout/killed), PID/exit-code labels, stop-and-remove + remove confirmation dialog
  • messaging.ts — search failure/retry, reasoning step counters, remove-tools-and-reasoning flow (replaces the old delete-message/bulk-delete keys), prompt background action, prompt queue (steer/queue delivery, actions, errors)
  • toolCall.tspermissionApproval.kind.form + new formRequest.* block (submit/cancel/errors/validation)
  • settings.ts — V2 update notice, provider command-auth method + waiting dialog, provider credit balance, follow-up behavior (steer vs queue)
  • commands.ts — stop-workspace and remove-session-technical-parts commands (labels/descriptions/keywords, keywords translated per existing convention)

Removed (35 keys) that no longer exist in en/: old delete-message/bulk-delete block, messageBlock.tool.deletePart.*, tauriNativeEventTransport, old background-process status/output/notify/stop/terminate keys.

Verification

  • Leaf-level parity check via direct module import: EN 1721 = TR 1721, missing 0, extra 0 (script in PR discussion)
  • {count}/{pid}/{toolCount} style placeholders preserved 1:1
  • Terminology consistent with the shipped glossary: "ek" (attachment), "Prompt" kept literal, "workspace" kept literal, keywords translated like existing entries

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

PR builds are available as GitHub Actions artifacts:

https://github.com/NeuralNomadsAI/CodeNomad/actions/runs/34338285232

Artifacts expire in 7 days.
Artifacts:

  • pr-685-0934305bd80d44c41d77338a7c2a5385c22c51c7-tauri-macos
  • pr-685-0934305bd80d44c41d77338a7c2a5385c22c51c7-tauri-windows
  • pr-685-0934305bd80d44c41d77338a7c2a5385c22c51c7-electron-macos
  • pr-685-0934305bd80d44c41d77338a7c2a5385c22c51c7-electron-linux
  • pr-685-0934305bd80d44c41d77338a7c2a5385c22c51c7-tauri-linux
  • pr-685-0934305bd80d44c41d77338a7c2a5385c22c51c7-tauri-macos-arm64
  • pr-685-0934305bd80d44c41d77338a7c2a5385c22c51c7-electron-windows

pascalandr

This comment was marked as outdated.

@pascalandr
pascalandr dismissed their stale review September 9, 2026 16:21

Reposting with a corrected explanation of the conditional OpenCode upgrade flow.

@pascalandr pascalandr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gatekeeper: key parity is correct, but the Turkish catalog is still not fully synced with V2 value changes. Comparing the #662 merge with this head found 11 keys whose English text changed while Turkish stayed byte-for-byte on the old meaning:

  • instance.ts:128,217,226,233: background-shell tooltip/empty/output text and opencodeBinarySelector.customPath.placeholder
  • messaging.ts:129: messagePart.actions.delete
  • settings.ts:13,235-238,289: active plugins, OpenCode version status text, and the mixed authentication method

The important mismatches are concrete: the shell tooltip still describes the old agent-process model; the mixed method omits command auth; and the binary placeholder drops {name}, so it says opencode while the UI passes opencode2. The four OpenCode card strings also retain their old update/check wording instead of the current English version/installed-version wording. This does not mean upgrades were removed: the update button correctly remains available when canUpgrade is true.

Please update all 11 values and rerun the global placeholder check. The 76 added keys, 35 removals, key count, build/typecheck, and CI otherwise check out.

@fitzgpt

fitzgpt commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

Updated all 11 values in fc8a155:

  • instance.ts:128 tooltip now describes native OpenCode background shells for the active workspace or worktree
  • instance.ts:217 empty state and instance.ts:226 output action now use the shell/output wording ("Arka plan kabuğu yok." / "Çıktıyı görüntüle")
  • instance.ts:233 placeholder restores {name}: "{name} binary yolunu girin…"
  • messaging.ts:129 messagePart.actions.delete is now "Sil"
  • settings.ts:13 plugins empty state is now "Etkin plugin yok."
  • settings.ts:235-238 OpenCode card reworded to version/installed-version semantics ("OpenCode sürümü", "Kurulu sürüm okunuyor...", etc.)
  • settings.ts:289 mixed method now "API anahtarı, OAuth veya komut"

Global check: EN/TR 1721/1721 keys, 0 missing, 0 extra, 0 placeholder mismatches. npm run typecheck passes for both workspaces.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

PR builds are available as GitHub Actions artifacts:

https://github.com/NeuralNomadsAI/CodeNomad/actions/runs/34391736894

Artifacts expire in 7 days.
Artifacts:

  • pr-685-f334d04fd7014083421797360131574be18dfdc9-tauri-macos
  • pr-685-f334d04fd7014083421797360131574be18dfdc9-tauri-windows
  • pr-685-f334d04fd7014083421797360131574be18dfdc9-electron-macos
  • pr-685-f334d04fd7014083421797360131574be18dfdc9-tauri-linux
  • pr-685-f334d04fd7014083421797360131574be18dfdc9-electron-linux
  • pr-685-f334d04fd7014083421797360131574be18dfdc9-tauri-macos-arm64
  • pr-685-f334d04fd7014083421797360131574be18dfdc9-electron-windows

@pascalandr pascalandr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gatekeeper: fixes verified on f334d04f. All 11 stale values now match the V2 semantics, including the restored {name} placeholder. EN/TR parity is 1,721/1,721 with no missing, extra, empty, or placeholder-mismatched entries. UI typecheck/build and git diff --check pass locally, and the full CI/build matrix is green.

Thanks @fitzgpt !

@pascalandr
pascalandr merged commit 889edbc into NeuralNomadsAI:dev Sep 9, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants