feat: make the verbose option print loaded config values before merging#118
Open
Wafffle77 wants to merge 1 commit into
Open
feat: make the verbose option print loaded config values before merging#118Wafffle77 wants to merge 1 commit into
Wafffle77 wants to merge 1 commit into
Conversation
Signed-off-by: Ethan Clark <ethan.clark@trojans.dsu.edu>
synackd
changed the title
synackd
requested changes
Jul 22, 2026
synackd
left a comment
synackd
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, just a small change.
Also, would it be useful as a user to see the merged config in early verbose mode?
| if err != nil { | ||
| return fmt.Errorf("failed to serialize config: %w", err) | ||
| } | ||
| log.EarlyLogger.BasicLogf("Config data: %s", serializedConfig) |
Collaborator
There was a problem hiding this comment.
Can we put a newline after Config data:? looks a bit awkward to have the first YAML key on the same line as the log message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make test(or equivalent) locally and all tests passgit commit -s) with my real name and email<filename>.licensesidecarLICENSES/directoryDescription
This PR makes the verbose option print the values it loaded from each config file before merging them, for debugging purposes.
Fixes #104
Type of Change
For more info, see Contributing Guidelines.