Skip to content

feat: make the verbose option print loaded config values before merging #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Wafffle77 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

feat: make the verbose option print loaded config values before merging #118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions internal/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,13 @@ func LoadGlobalConfigMerged() error {
}
} else {
log.EarlyLogger.BasicLogf("merging in config from %s", cfgLoaded.File)

serializedConfig, err := GetConfigString(cfgLoaded.Cfg, "", "yaml")
if err != nil {
return fmt.Errorf("failed to serialize config: %w", err)
}
log.EarlyLogger.BasicLogf("Config data: %s", serializedConfig)

@synackd synackd Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put a newline after Config data:? looks a bit awkward to have the first YAML key on the same line as the log message.


if err := MergeConfigIntoParser(ko, cfgLoaded.Cfg); err != nil {
return fmt.Errorf("failed to merge config: %w", err)
}
Expand Down
Loading