Test battery ID selection - #138
Merged
Merged
Conversation
Stack the request-driven Battery handler with two distinct dev-QEMU fuel gauges so the relay E2E proves that battery IDs select different packs. Assisted-by: GitHub Copilot:gpt-5.6-sol Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a3539bc8-3a1f-44b3-ba4a-c171a7822595
Advance the embedded-controller stack to include battery IDs in per-gauge error logs requested during review. Assisted-by: GitHub Copilot:gpt-5.6-sol Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a3539bc8-3a1f-44b3-ba4a-c171a7822595
Advance the embedded-controller stack to the platform-common formatting fix required by CI. Assisted-by: GitHub Copilot:gpt-5.6-sol Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a3539bc8-3a1f-44b3-ba4a-c171a7822595
Replace the temporary fork pins with the merged upstream EC and secure-services commits so the E2E stack is ready for upstream review. Assisted-by: GitHub Copilot:gpt-5.6-sol Copilot-Session: a3539bc8-3a1f-44b3-ba4a-c171a7822595
kurtjd
approved these changes
Jul 29, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the battery E2E test to validate battery-ID selection end-to-end by issuing GetBst requests for battery IDs 0 and 1 and asserting that the returned pack voltage differs between the two mock fuel-gauge profiles.
Changes:
- Split the single BST assertion into two checks (battery 0 and battery 1).
- Introduce a small helper (
check_battery_bst) to share the common BST parsing/assertion logic while varying expected voltage per battery ID. - Improve logging/output labeling so pass/fail results are attributed to the specific battery-ID test case.
philgweber
approved these changes
Jul 29, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependencies
Validation
./.husky/pre-commitmake ec uefimake -C e2e-tests relay-run-battery SERIAL_TEE=1Battery 0 returns 11850 mV; battery 1 returns 7900 mV.