Fix java/regex-injection CodeQL alert in TargAttrFilters - #760
Merged
vharseko merged 1 commit intoJul 25, 2026
Merged
Conversation
The targattrfilters ACI decoder embedded the operation keyword captured from the user-supplied expression directly into a regular expression (opPattern) used to split the sub-expression. Although the captured group can only ever be the literal "add" or "del" (it comes from the (add|del) capture group of keywordFullPattern), CodeQL flags the user-tainted value flowing into a regex. Wrap the captured operation in Pattern.quote() before embedding it into opPattern. For "add"/"del" this is a no-op at match time, so behaviour is unchanged, while the regex-injection data flow is removed.
vharseko
added
java
maximthomas
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CodeQL
java/regex-injectionalert #88 inTargAttrFilters.decode().The
targattrfiltersACI decoder builtopPattern— a regular expression used tosplit()the sub-expression — by concatenating the operation keyword captured from the user-supplied ACI expression. The captured group can in practice only ever be the literal"add"or"del"(it comes from the(add|del)capture group ofkeywordFullPattern), so this is not exploitable, but the user-tainted value still flows into a regex and is flagged by CodeQL.Change
Wrap the captured operation in
Pattern.quote()before embedding it intoopPattern. For"add"/"del"this is a no-op at match time (\Qadd\Ematches the literaladd), so runtime behaviour is unchanged, while the regex-injection data flow is removed.Notes
X-PATTERNinLDAPSyntaxDescriptionSyntaxImpl) is intentionally not addressed here: that value is a regular expression by design (an LDAP syntax definition writable only with schema-write/administrative privileges), soPattern.quote()is not applicable there.