Skip to content

Fix java/regex-injection CodeQL alert in TargAttrFilters #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vharseko merged 1 commit into from
Jul 25, 2026
Merged

Fix java/regex-injection CodeQL alert in TargAttrFilters #760

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...rver-legacy/src/main/java/org/opends/server/authorization/dseecompat/TargAttrFilters.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
*
* Copyright 2008 Sun Microsystems, Inc.
* Portions Copyright 2013-2016 ForgeRock AS.
* Portions Copyrighted 2026 3A Systems, LLC.
*/
package org.opends.server.authorization.dseecompat;

Expand Down Expand Up @@ -137,9 +138,12 @@ public static TargAttrFilters decode(EnumTargetOperator type,
//This pattern is built dynamically and is used to see if the operations
//in the two filter list parts (if the second exists) are equal. See
//comment below.
// firstOp is captured from the (add|del) group of keywordFullPattern, so it can
// only ever be the literal "add" or "del". Quote it defensively before embedding it
// into another regular expression to avoid any regex-injection into opPattern.
String opPattern=
"[,]{1}" + ZERO_OR_MORE_WHITESPACE +
firstOp + ZERO_OR_MORE_WHITESPACE + EQUAL_SIGN +
Pattern.quote(firstOp) + ZERO_OR_MORE_WHITESPACE + EQUAL_SIGN +
ZERO_OR_MORE_WHITESPACE;
String[] temp=subExpression.split(opPattern);
/*
Expand Down
Loading