Skip to content

Fix test that tripped its own CONSOLE READ-ONLY grep check #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shreyastek merged 1 commit into from
Sep 13, 2026
Merged

Fix test that tripped its own CONSOLE READ-ONLY grep check #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions tests/test_response_actions_proxy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,15 +81,16 @@ def test_returns_502_when_manager_unreachable(self):

def test_console_source_never_gains_a_mutating_route(self):
# The CI-enforced "CONSOLE READ-ONLY" invariant (panopticon-diagrams'
# _tooling/validate.py) checks for these substrings across the whole
# repo; pin it here too so a regression fails fast in this repo's own
# CI, not only downstream in diagrams'.
# _tooling/validate.py) greps every .py/.js file in this repo -- test
# files included -- for these two literal substrings, so they are
# built here rather than written out directly to avoid this very
# test tripping the check it's meant to pin.
mutating_handlers = ["do_" + "POST", "do_" + "PUT"]
source = (Path(__file__).resolve().parent.parent / "app.py").read_text(encoding="utf-8")
js_source = (Path(__file__).resolve().parent.parent / "static" / "app.js").read_text(encoding="utf-8")
self.assertNotIn("do_POST", source)
self.assertNotIn("do_PUT", source)
self.assertNotIn("do_POST", js_source)
self.assertNotIn("do_PUT", js_source)
for handler in mutating_handlers:
self.assertNotIn(handler, source)
self.assertNotIn(handler, js_source)


if __name__ == "__main__":
Expand Down
Loading