Skip to content

[PER-10476] Migrate navigation consumers to getWithChildren#1089

Draft
aasandei-vsp wants to merge 1 commit into
PER-10476-replace-navigate-leanfrom
PER-10476-replace-navigate-lean-v2
Draft

[PER-10476] Migrate navigation consumers to getWithChildren#1089
aasandei-vsp wants to merge 1 commit into
PER-10476-replace-navigate-leanfrom
PER-10476-replace-navigate-lean-v2

Conversation

@aasandei-vsp

@aasandei-vsp aasandei-vsp commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Issue: PER-10476
Subtask: https://permanent.atlassian.net/browse/PER-10678

Do not merge before #996

Manual test cases — Replace navigateLean with getWithChildren

Setup: log in on an archive with nested folders, records, a shared folder, and a folder set to Timeline view.
EXPECTED: all folder navigation now goes through the Stela v2 endpoints — the flows below cover every migrated consumer.


Private navigation

  1. Log in and open My Files.
    • EXPECTED: The folder contents load with correct names and thumbnails.
  2. Copy the URL of a nested folder and open it in a new tab.
    • EXPECTED: The folder loads directly from the URL (this path resolves the folder id through the legacy endpoint first).
  3. Navigate several levels deep, then go back up using the breadcrumbs.
    • EXPECTED: Breadcrumb labels are correct and each link navigates to the right folder.
  4. Edit the URL to a nonexistent folderLinkId.
    • EXPECTED: An error toast appears and you are redirected to My Files — no blank page.

Apps folder

  1. Navigate to /apps.
    • EXPECTED: The Apps folder contents load correctly.

Share preview

  1. Open a share link to a shared folder.
    • EXPECTED: The shared folder contents load.
  2. Open a share link to a single record.
    • EXPECTED: The record preview renders with the Shares > Record breadcrumb.

Public archive

  1. Visit your public archive (/p/archive/...) and browse into folders.
    • EXPECTED: Contents load; opening a record works.

Timeline view

  1. Open a folder set to Timeline view and click a folder inside the timeline.
    • EXPECTED: The clicked folder's contents load in the timeline without errors.

Folder content refresh

  1. Upload a file into a folder.
    • EXPECTED: The listing refreshes and shows the new file without a manual reload.
  2. Rename, move, and delete an item.
    • EXPECTED: The folder refreshes correctly after each operation.
  3. Change the sort order.
    • EXPECTED: The list re-sorts and the order persists after navigating away and back.

Publish dialog

  1. Open Publish on a private folder.
    • EXPECTED: The title reads "Publish " and there are no TypeErrors in the console. (Bug fix in this PR — the template read folder_linkType unguarded, which Stela folders don't have.)
  2. Open Publish on an already-public item.
    • EXPECTED: The title reads "Get public link for " and the link is shown.
  3. Publish a record and follow its link.
    • EXPECTED: The record opens in the public view.
  4. Publish a folder and follow its link.
    • EXPECTED: The public copy opens and shows its contents. (Known open issue: the copy may appear empty — under investigation with the backend team; capture the v2/folder/{id}/children response if it reproduces.)

Replace navigateLean with getWithChildren in the lean folder
resolver, the filesystem API service, and the timeline view. The
resolver detects the error-shaped response getWithChildren returns
on failure and keeps its logout/redirect handling; the filesystem
service now uses a single code path for regular and unlisted-share
navigation.

Issue: PER-10476
@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.32%. Comparing base (e54b14f) to head (5bbdd9f).

Files with missing lines Patch % Lines
...c/app/core/resolves/lean-folder-resolve.service.ts 80.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@                         Coverage Diff                         @@
##           PER-10476-replace-navigate-lean    #1089      +/-   ##
===================================================================
+ Coverage                            52.14%   52.32%   +0.17%     
===================================================================
  Files                                  354      355       +1     
  Lines                                12095    12130      +35     
  Branches                              2183     2190       +7     
===================================================================
+ Hits                                  6307     6347      +40     
+ Misses                                5562     5553       -9     
- Partials                               226      230       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aasandei-vsp aasandei-vsp changed the title Migrate navigation consumers to getWithChildren [PER-10476] Migrate navigation consumers to getWithChildren Jul 16, 2026
@aasandei-vsp aasandei-vsp self-assigned this Jul 16, 2026
@aasandei-vsp
aasandei-vsp marked this pull request as draft July 16, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant