[PER-10476] Migrate navigation consumers to getWithChildren#1089
Draft
aasandei-vsp wants to merge 1 commit into
Draft
[PER-10476] Migrate navigation consumers to getWithChildren#1089aasandei-vsp wants to merge 1 commit into
aasandei-vsp wants to merge 1 commit into
Conversation
Replace navigateLean with getWithChildren in the lean folder resolver, the filesystem API service, and the timeline view. The resolver detects the error-shaped response getWithChildren returns on failure and keeps its logout/redirect handling; the filesystem service now uses a single code path for regular and unlisted-share navigation. Issue: PER-10476
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## PER-10476-replace-navigate-lean #1089 +/- ##
===================================================================
+ Coverage 52.14% 52.32% +0.17%
===================================================================
Files 354 355 +1
Lines 12095 12130 +35
Branches 2183 2190 +7
===================================================================
+ Hits 6307 6347 +40
+ Misses 5562 5553 -9
- Partials 226 230 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
aasandei-vsp
marked this pull request as draft
July 16, 2026 12:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: PER-10476
Subtask: https://permanent.atlassian.net/browse/PER-10678
Do not merge before #996
Manual test cases — Replace navigateLean with getWithChildren
Setup: log in on an archive with nested folders, records, a shared folder, and a folder set to Timeline view.
EXPECTED: all folder navigation now goes through the Stela v2 endpoints — the flows below cover every migrated consumer.
Private navigation
folderLinkId.Apps folder
/apps.Share preview
Public archive
/p/archive/...) and browse into folders.Timeline view
Folder content refresh
Publish dialog
TypeErrors in the console. (Bug fix in this PR — the template readfolder_linkTypeunguarded, which Stela folders don't have.)v2/folder/{id}/childrenresponse if it reproduces.)