[PER-10476] Migrate publish dialog and fix title crash for Stela folders#1090
Draft
aasandei-vsp wants to merge 1 commit into
Draft
[PER-10476] Migrate publish dialog and fix title crash for Stela folders#1090aasandei-vsp wants to merge 1 commit into
aasandei-vsp wants to merge 1 commit into
Conversation
Replace navigateLean with getWithChildren in the publish polling loop. Compute the dialog title from a component property that also checks the item type, since folders loaded through the Stela API have no folder_linkType and the raw template access threw a TypeError on every change detection cycle. Issue: PER-10476
aasandei-vsp
marked this pull request as draft
July 16, 2026 12:19
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## PER-10476-replace-navigate-lean-v2 #1090 +/- ##
======================================================================
- Coverage 52.32% 52.32% -0.01%
======================================================================
Files 355 355
Lines 12130 12133 +3
Branches 2190 2191 +1
======================================================================
+ Hits 6347 6348 +1
- Misses 5553 5559 +6
+ Partials 230 226 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: PER-10476
Subtask: https://permanent.atlassian.net/browse/PER-10679
Do not merge before #1089
Manual test cases — Publish dialog migration and title crash fix
Setup: log in on an archive with at least one private folder (with items), one private record, and one already-published item.
EXPECTED: only the Publish dialog is affected by this PR — opening it, its title, and the folder publish flow.
Dialog title — private items
TypeErrors appear in the console. (Bug fix — the template readfolder_linkTypeunguarded, which folders loaded through the Stela API don't have, causing a repeating TypeError on every change detection cycle.)Dialog title — already-public item
Publishing a folder
v2/folder/{id}/childrenresponse.)Publishing a record