Skip to content

Fail on unmerged LoRA keys during JAX conversion#984

Open
J0YY wants to merge 1 commit into
Physical-Intelligence:mainfrom
J0YY:contrib/openpi-convert-lora-adapters
Open

Fail on unmerged LoRA keys during JAX conversion#984
J0YY wants to merge 1 commit into
Physical-Intelligence:mainfrom
J0YY:contrib/openpi-convert-lora-adapters

Conversation

@J0YY

@J0YY J0YY commented Jun 24, 2026

Copy link
Copy Markdown

Summary

  • Capture load_state_dict results in the JAX to PyTorch converter
  • Raise a clear error when unexpected LoRA keys remain after conversion
  • Prevent saving PyTorch checkpoints that would silently drop LoRA adapters

Scope

  • This is a guard against incorrect converted weights
  • It does not implement LoRA adapter merging

Verification

  • python3 -m py_compile examples/convert_jax_model_to_pytorch.py
  • git diff --check

Addresses #958

@J0YY J0YY marked this pull request as ready for review June 24, 2026 05:19
@jimmyt857 jimmyt857 removed their request for review June 24, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant