Skip to content

Fail on unmerged LoRA keys during JAX conversion #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
J0YY wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fail on unmerged LoRA keys during JAX conversion #984

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion examples/convert_jax_model_to_pytorch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,14 @@ def __init__(self):
all_params = {**paligemma_params, **gemma_params, **projection_params}

# Load state dict
pi0_model.load_state_dict(all_params, strict=False)
load_result = pi0_model.load_state_dict(all_params, strict=False)
unexpected_lora_keys = [key for key in load_result.unexpected_keys if "lora" in key.lower()]
if unexpected_lora_keys:
raise ValueError(
"LoRA adapter weights were found after conversion, but this converter does not merge LoRA adapters yet. "
"Saving this checkpoint would silently drop the adapters and produce incorrect PyTorch weights. "
f"Unexpected LoRA keys: {unexpected_lora_keys}"
)

if precision == "float32":
pi0_model = pi0_model.to(torch.float32)
Expand Down