Use message_filters hpp headers - #1148
Conversation
This upstreams RoboStack build fix patch/ros-rolling-turtlebot3-node.win.patch. Best guess rationale: the message_filters C++ headers are provided as .hpp in current ROS 2. Including the .hpp headers avoids relying on deprecated .h compatibility headers and keeps turtlebot3_node aligned with Rolling dependencies. Signed-off-by: Tobias Fischer <info@tobiasfischer.info>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the include headers in odometry.hpp to use the .hpp extension instead of .h for message_filters dependencies. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Pull request overview
Updates turtlebot3_node’s odometry header to include the current ROS 2 message_filters C++ headers (.hpp) rather than relying on legacy/deprecated .h compatibility headers, aligning the node with Rolling dependency packaging.
Changes:
- Switch
message_filtersincludes inodometry.hppfrom.hto.hppvariants to match current ROS 2 header layout.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
FYI @wep21 and @traversaro: this upstreams a RoboStack downstream patch tracked in RoboStack/robostack.github.io#16. |
This is part of an effort to contribute RoboStack downstream patches back upstream.
Origin: patch/ros-rolling-turtlebot3-node.win.patch, authored by Daisuke Nishimatsu.
Best-guess rationale: the message_filters C++ headers are provided as .hpp in current ROS 2. Including the .hpp headers avoids relying on deprecated .h compatibility headers and keeps turtlebot3_node aligned with Rolling dependencies.