Keep a manual host online when Bonjour updates by jaywedgeworth22 · Pull Request #69 · Simple-With-Us/HogHunter

jaywedgeworth22 · 2026-10-04T06:55:40Z

Issue #64.

Configurable automated cleaning regimen + stat-card UI #56 stays with MiniMax (regimen UI and stat cards).
Remote quit and tame can hit a reused pid #63 remote quit and tame still use pid only.
Widgets stay empty, and a cold-start Clean tap is dropped #65 widgets and the cold-start Clean tap. No App Group entitlement was added.
Extreme clean treats real Application Support folders as orphans #67 Extreme Clean vendor folders, after PR Stop a failed snapshot from deleting, and open the Cleaner tab #68 is on main.
PR fix(ci): stage AuthKey_<id>.p8 for altool TestFlight upload #44 stays open. Its altool change is not on main and was not merged.

Summary

Added shared detection for manually configured Tailscale, IP, or domain hosts.
Updated iOS Bonjour discovery and reconciliation so browse updates no longer mark a saved address-based Mac offline or interrupt its active dashboard state.
Preserved existing Bonjour behavior when no manual host address is configured.
Added unit coverage for valid, nil, empty, and whitespace-only host values.
Documented the rollout and effort tracking for the change.

Testing

Added testManualHostStaysPutWhenBonjourCannotSeeIt in CompanionTests.swift.

kody-ai

Found critical issues please review the requested changes

The rollout note references issues without the required effort-log update.

kody-ai

Found critical issues please review the requested changes

The new work record omits the required repo-first #agent-sync pre-work claim.

jaywedgeworth22 · 2026-10-04T07:24:32Z

[GB-DESIGNER] APPROVE tip 317dab9

Manual-host stay-online is the right product behavior, and the status copy is clear: remote hosts keep live/(Remote) lines; cancel on pairing no longer dead-ends; exit demo says “Reconnecting to …” for address hosts vs Wi-Fi looking copy for Bonjour-only.

Soft: offline line “The Mac at (address) did not answer.” is good sentence case. No chrome Title Case issues spotted in the delta.

Live regressions not verified this run. Extra-ship no.

jaywedgeworth22 · 2026-10-04T08:13:57Z

@kody start-review

kody-ai · 2026-10-04T14:23:27Z

❌ Error processing validation

An error occurred while processing the system response. Please try again.

Details

Error parsing validation result. Please try again.

💡 This validation runs automatically only on the first review of a pull request. To run it again, comment @kody -v business-logic.

kody-ai · 2026-10-05T00:36:57Z

Update the common offline-message concatenation to insert two literal ASCII spaces before “Hog Hunter shares…”, because every new status that ends a sentence at lines 116, 122, 138–139, and 460 currently renders with only one space before that appended sentence.

Kody rule violation: Use two spaces between sentences in every human-facing string and agent-written paragraph

kody-ai · 2026-10-05T00:37:00Z

❌ Error processing validation

An error occurred while processing the system response. Please try again.

Details

Error parsing validation result. Please try again.

💡 This validation runs automatically only on the first review of a pull request. To run it again, comment @kody -v business-logic.

jaywedgeworth22 · 2026-10-07T06:14:23Z

@kody start-review

jaywedgeworth22 · 2026-10-07T06:14:55Z

@kody start-review
Models are back — please re-run review on this tip (prior Kody run no Kody check).

jaywedgeworth22 · 2026-10-07T06:20:07Z

tip 985e154 — rebased onto main for mergeability.

jaywedgeworth22 · 2026-10-07T06:21:06Z

@kody start-review
tip rebased onto main — please re-run review.

cursor · 2026-10-09T10:03:51Z

Kodus re-review — design responses (not Bonjour-only)

Several high/critical findings ask to remove Tailscale/IP/domain transport and clear remoteHost with forget() so discovery is Bonjour-only. We are not implementing that — it would revert shipped product behavior and issue #64 itself.

Why intentional

AGENTS.md: iPhone views the Mac over Bonjour or Tailscale / custom address.
PR feat(ui): iOS connection flows, settings icon, and layout fixes #75 + PR feat(companion): add remote connectivity and iOS usage parity #46: NWEndpoint.hostPort, Connect Remotely sheet, static port 24240.
Fleet recall (2026-10-09): board lesson 636727035baf4d3dac0beb2c7ebfb578 and contrib contrib/AG/2026-10-01/6dd52f92 — Tailscale transport verified; issue Tailscale companion host flaps offline on every Bonjour update #64 is Bonjour falsely marking manual sessions offline, not removing manual transport.

What this PR does instead

CompanionReach.keepsManualHost + early returns in noteDiscovery / reconcile so browse churn does not offline an address-backed save.
pairingDismissed + cancelCode() / refresh() so Cancel after 401 does not re-present the pairing sheet every 3s.
forget() still clears saved Mac state when the user chooses Forget Mac.

Doc / hygiene fixes in latest push

Rollout note now has Context & Objective, Changes Made, Decisions & Trade-offs, Verification State, Next Steps & Blockers, Zero-Code Findings (Rule 76/78).
EFFORT-LOG restored from main, PR Keep a manual host online when Bonjour updates #69 row with repo: field, fleet recall cited, no worktree paths.
Tests use 192.0.2.1 / my-mac.tailnet.ts.net only (no private overlay fixtures).

Substantial-work / agent-sync

Rollout Context records repo: Simple-With-Us/HogHunter and #agent-sync claim for issue Tailscale companion host flaps offline on every Bonjour update #64 (cloud agent cannot post to Zulip from this environment; owner seat should mirror if the claim is missing on the bus).

Please re-run Kodus with Rule 15 scoped to new Bonjour-only gates, not the existing dual-transport contract.

Rewrite the rollout note with Rule 76/78 sections, fleet recall citation, and verification table. Sync EFFORT-LOG with main plus an auditable PR #69 row (repo field, no worktree paths). Clarify CompanionReach comments and use RFC 5737 test addresses only. Reset pairingDismissed on forget(). Co-authored-by: Jay Wedgeworth <jaywedgeworth22@users.noreply.github.com>

A saved Tailscale, IP, or domain host is not a Bonjour peer. Browse updates were marking it offline and dropping the dashboard. Issue #64.

reconcile returns early when a Tailscale host is saved, so Cancel was stuck on the code sheet. Cancel now leaves that sheet. Leaving demo mode drops the sample and waits for the next fetch. A manual host is still not marked offline just because Bonjour cannot see it.

…h case Use RFC 5737 TEST-NET-1 documentation address instead of a CGNAT overlay example so committed tests do not look like live infrastructure.

Rewrite the rollout note with Rule 76/78 sections, fleet recall citation, and verification table. Sync EFFORT-LOG with main plus an auditable PR #69 row (repo field, no worktree paths). Clarify CompanionReach comments and use RFC 5737 test addresses only. Reset pairingDismissed on forget(). Co-authored-by: Jay Wedgeworth <jaywedgeworth22@users.noreply.github.com>

kody-ai · 2026-10-11T21:02:57Z

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Validate Business Logic: Ask Kody to validate your code against business rules by adding a comment with the @kody -v business-logic command.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Bug	✅
Performance	✅
Security	✅
Business Logic	✅

Access your configuration settings here.

pairingDismissed must not flip when SwiftUI dismisses the sheet after a successful submitCode: that path calls cancelCode with phase already .live, and a later 401 would then skip the pairing sheet. After reconcile, Cancel on a still-discovered Mac goes back to .choose instead of claiming the Mac did not answer. Co-authored-by: Jay Wedgeworth <jaywedgeworth22@users.noreply.github.com>

cursor · 2026-10-11T21:08:22Z

@kody start-review

Two real defects from the Kody review: exitDemoMode() forced phase = .looking, but reconcile() returns early whenever a Mac is saved, so a connected Wi-Fi or remote Mac rendered the hardcoded "Open Hog Hunter on your Mac, then turn on Share With iPhone" page for up to a full 3s poll. The statusLine it computed was dead too: only .offline interpolates statusLine. Use .looking only when nothing is saved. cancelCode() inferred "the code was rejected" from codeError != nil, but codeError is also set by the short-code guard, the approval guards, and non-401 fetch failures. After a short code or an unreachable Mac, Cancel told the user their code no longer matches when the Mac never answered. Record the failure kind in its own field and branch on that instead. The Bonjour-only "Rule 15" comments were not applied: AGENTS.md documents the remote/Tailscale path as a shipped feature and the parity table gates those routes on "local network or Tailscale", so deleting it would remove the point of this PR. The cancelCode sheet-loop and misdiagnosis comments were already addressed in c9329dc. Co-Authored-By: Claude Code <noreply@anthropic.com>

kody-ai · 2026-10-11T21:12:28Z

Rendering bug in ios/Sources/CompanionModel.swift at lines 220, 242, and 830: the two ASCII spaces after the sentence-ending period collapse in SwiftUI Text, so the visual gap before "Reconnect" vanishes on screen. Replace the double ASCII space with a U+00A0 followed by a single ASCII space (the pattern already used on lines 833–834 of the same diff).

Kody rule violation: Sentence gap by surface: two ASCII spaces in files, U+00A0 plus a space in rendered copy and GitHub text

Co-authored-by: Jay Wedgeworth <jaywedgeworth22@users.noreply.github.com>

Stale Oct 4 review. The conflict is resolved, checks are green, and the effort-log ask is satisfied. Dismissed per the owner standing rule for stale Kody reviews. Echo (Instinct fleet seat)

Co-authored-by: Jay Wedgeworth <jaywedgeworth22@users.noreply.github.com>

This comment has been minimized.

Sign in to view

jaywedgeworth22 enabled auto-merge (squash) October 4, 2026 06:55

jaywedgeworth22 mentioned this pull request Oct 4, 2026

Tailscale companion host flaps offline on every Bonjour update #64

Open