Skip to content

fix: close runtime review findings and enforce integration evidence - #7

Merged
brianvarskonst merged 4 commits into
mainfrom
fix/review-findings
Sep 30, 2026
Merged

brianvarskonst merged 4 commits into
mainfrom
fix/review-findings

Conversation

@brianvarskonst

Copy link
Copy Markdown
Member

General WP Starter projects could lose early Composer classes/hooks, and disabling compatibility still honored two legacy environment controls. Restore those behaviors explicitly while retaining the independent native parser payload.

  • Add wp-config-autoload: native default false, both legacy profiles true, with explicit overrides and migration guidance. Exact differential cases verify Composer files hooks and vendor classes before environment PHP and early hooks.
  • Honor compatibility=false for the legacy loaded marker and constant mapping in runner, generated configuration, doctor and warm dumps/caches. Reject compatibility-mode cache mismatches with explicit regeneration guidance; keep WordPress environment aliases.
  • Bound streamed URL-service downloads with configurable download-max-bytes (16 MiB default). Failed verification or oversized responses preserve destinations; uppercase checksum input has regression coverage.
  • Provision disposable MariaDB, VCS clients and pinned, SHA-256-verified WordPress/WP-CLI fixtures in CI; execute the complete PHPUnit suite with --fail-on-skipped before parity evidence and differential comparisons.
  • Complete user and deployment guides, document rollback-safe payload retention, update project status, and identify source-derived API files individually in NOTICE.
  • Tighten the consumer browser harness to require root login, form action and dashboard URLs. Consumer configuration corrections remain in starter Remove persisted process-secret verifiers from environment caches #29 and demo chore: release runtime 1.2.8 #49; their Nginx files match their original bases.

Validation: complete local QA passes with 1,059 tests / 7,365 assertions and no skips, coding standards and PHPStan max. All 407 source inventory rows have executed behavioral evidence. All 251 isolated differential cases and the evidence checker's four tests pass. Actionlint passes. Both consumer browser checks pass with root URL assertions; starter QA is 7 tests / 49 assertions and demo QA is 27 tests / 213 assertions plus live REST/block/render/ORM smoke. The new no-skip remote CI gate is required before merging this correction.

The consumer repositories still require an authorized CI credential to read private Runtime. GitHub rejects deploy keys for Runtime; no deploy key or temporary SSH secret was retained. This PR does not change that policy or claim final consumer/full-drop-in acceptance.

@brianvarskonst
brianvarskonst merged commit 60249ee into main Sep 30, 2026
5 checks passed
@brianvarskonst
brianvarskonst deleted the fix/review-findings branch September 30, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant