Ambulance data - #67
Open
AtticusTarleton wants to merge 18 commits into
Open
Conversation
…at there is a map on the website. more work is still needed
# Conflicts: # backend/Data/_Processed/all_data.duckdb # backend/query/__init__.py
iansargent
reviewed
Aug 3, 2026
iansargent
left a comment
iansargent
left a comment
Collaborator
There was a problem hiding this comment.
Looks good Atticus! Pretty close to your other work with wastewater, so it was pretty easy to parse. Thank you for being consistent.
FWJK1
reviewed
Aug 3, 2026
FWJK1
reviewed
Aug 3, 2026
FWJK1
reviewed
Aug 3, 2026
FWJK1
reviewed
Aug 3, 2026
FWJK1
reviewed
Aug 3, 2026
FWJK1
reviewed
Aug 3, 2026
FWJK1
requested changes
Aug 3, 2026
FWJK1
left a comment
FWJK1
left a comment
Collaborator
There was a problem hiding this comment.
A few comments requesting changes throughout. Generally looks good.
FWJK1
reviewed
Aug 7, 2026
FWJK1
left a comment
FWJK1
left a comment
Collaborator
There was a problem hiding this comment.
Atticus, just request my review again when you think this is ready to go.
Collaborator
Author
|
This is failing some ruff format checks, but I went back and looked and they are all from files this pull request did not change, but rather from files that were updated when I merged it with main |
FWJK1
requested changes
Aug 19, 2026
FWJK1
left a comment
FWJK1
left a comment
Collaborator
There was a problem hiding this comment.
Looks good,but can you:
- Add a legend to this, similar to your other legend.
- Can you make the borders around the areas significantly thicker? And set the county lines to start off. Otherwise it's a bit confusing. LMK if you need helping thinking about the borders as it's a bit tricky, potentially.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A large PR that adds ambulance service data to the website
cleans ambulance service data and creates clean parquet files
creates a build script for ambulance service tables
created a query script for ambulance service tables
updates schema to include filter information for ambulance service tables
creates post routes for ambulance service tables in the API
modifies the frontend typescript so that the new maps are accessible from the website