Skip to content

Environments: Fix jobs, WordPress.tv and Support Forums envs failing to start - #1205

Closed
obenland wants to merge 1 commit into
WordPress:trunkfrom
obenland:fix/wp-env-file-mountpoints
Closed

obenland wants to merge 1 commit into
WordPress:trunkfrom
obenland:fix/wp-env-file-mountpoints

Conversation

@obenland

@obenland obenland commented Nov 7, 2026 •

Copy link
Copy Markdown
Member

Docker Desktop's runc (1.3.5) won't create a single-file mountpoint inside the core directory wp-env bind-mounts:

error mounting ".../mocks/mu-plugins/wporg-dev-login.php" to rootfs at "/var/www/html/wp-content/mu-plugins/wporg-dev-login.php": ... mountpoint ".../wordpress-latest/wp-content/mu-plugins/wporg-dev-login.php" is outside of rootfs

wp-env re-extracts the nightly core zip whenever the config changes, so the mountpoint never exists ahead of time and start fails every time. Directory mountpoints are unaffected. This hits every env that maps a single file: jobs, WordPress.tv and Support Forums.

This maps only directories:

  • jobs and WordPress.tv: their own mu-plugins move into jobs/mu-plugins/ and wordpress-tv/mu-plugins/, mapped as wp-content/mu-plugins. The shared dev login helper stays in mocks/mu-plugins/ (the other envs map that whole directory), reached through a mapped wp-content/env-mocks and a one-line loader.
  • Support Forums: wporg-ratings.php moves into plugins/wporg-ratings/, mapped as a directory.

Testing

  • npm run wptv:env start: starts after a fresh core extraction; dev-login.php and wptv-local.php load, and the login screen shows the dev login button.
  • npm run jobs:env start: dev-login.php, jetpack-offline-subscriptions.php and jobs-open-to-work.php load.
  • npm run support:env start: starts; wporg-ratings is active on the plugins and themes sites.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated local development environment configuration for Jobs and WordPress.tv to load shared mock resources and the development login helper.
    • Updated the support-forums environment to map the ratings plugin by its directory.
  • Documentation
    • Corrected the documented location of the WordPress.tv local configuration file. Offline-mode behavior is unchanged.

Docker Desktop's runc (1.3.5) refuses to create a single-file mountpoint inside the core directory wp-env bind-mounts, failing with "mountpoint ... is outside of rootfs". wp-env re-extracts the nightly core zip whenever the config changes, so the jobs, WordPress.tv and Support Forums environments couldn't start.

Map directories instead: each environment's own mu-plugins move into a per-environment mu-plugins directory, the shared dev login helper is reached through a mapped mocks directory, and the local wporg-ratings plugin gets its own directory.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings November 7, 2026 15:04

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props obenland.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@coderabbitai

coderabbitai Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Jobs and WordPress.tv now mount MU-plugin directories and shared mocks, and add loaders for the shared development login helper. Support-forums now maps the wporg-ratings plugin directory. The README updates the WordPress.tv configuration path.

Changes: Environment plugin mounts

Layer / File(s) Summary
Shared mock mounts and login loaders
environments/jobs/.wp-env.json, environments/jobs/mu-plugins/dev-login.php, environments/wordpress-tv/.wp-env.json, environments/wordpress-tv/mu-plugins/dev-login.php, environments/README.md
Jobs and WordPress.tv map their MU-plugin directories and wp-content/env-mocks to local directories. Each environment adds a loader for the shared development login helper. The README updates the WordPress.tv configuration path.
Ratings plugin directory mapping
environments/support-forums/.wp-env.json, environments/support-forums/plugins/wporg-ratings/wporg-ratings.php
The environment maps the wporg-ratings plugin directory instead of its individual PHP file. The plugin header now identifies the directory path.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related PRs

Merge Risk: Minimal · up to 2bc6e

The directory mappings preserve the expected plugin paths. No merge-blocking issue was identified.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the startup fixes for the three affected environments.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 3 files. (4 skipped: 4 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4a7d8112-7991-4af2-8edf-9e6211254d22
Commits

Reviewing files that changed from the base of the PR and between 82f0414 and 2bc6e87.

Files selected for processing: 10

  • environments/README.md
  • environments/jobs/.wp-env.json
  • environments/jobs/mu-plugins/dev-login.php
  • environments/jobs/mu-plugins/jetpack-offline-subscriptions.php
  • environments/jobs/mu-plugins/jobs-open-to-work.php
  • environments/support-forums/.wp-env.json
  • environments/support-forums/plugins/wporg-ratings/wporg-ratings.php
  • environments/wordpress-tv/.wp-env.json
  • environments/wordpress-tv/mu-plugins/dev-login.php
  • environments/wordpress-tv/mu-plugins/wptv-local.php

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants