In-database BIDS file information - #1443
Open
MaximeBICMTL wants to merge 5 commits into
Open
Conversation
MaximeBICMTL
force-pushed
the
bids-info
branch
3 times, most recently
from
June 22, 2026 13:30
b1400ce to
40953c6
Compare
MaximeBICMTL
force-pushed
the
bids-info
branch
4 times, most recently
from
June 23, 2026 09:39
7ebbfbe to
febe169
Compare
MaximeBICMTL
force-pushed
the
bids-info
branch
from
August 11, 2026 23:38
febe169 to
32aa1c0
Compare
MaximeBICMTL
force-pushed
the
bids-info
branch
2 times, most recently
from
August 13, 2026 13:06
d9d071d to
bec013b
Compare
maximemulder
marked this pull request as ready for review
August 13, 2026 13:06
MaximeBICMTL
requested review from
cmadjar and
ridz1208
and removed request for
cmadjar and
ridz1208
August 13, 2026 13:23
MaximeBICMTL
force-pushed
the
bids-info
branch
from
August 13, 2026 15:18
5b82f12 to
5aebba9
Compare
MaximeBICMTL
force-pushed
the
bids-info
branch
from
August 14, 2026 06:03
5aebba9 to
48c909c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements aces/Loris#11169 for the LORIS BIDS MRI and EEG importer. Code-wide, this PR improves the BIDS importer by refactoring
BidsImportEnvinto a more feature-completeBidsImporterclass. However, the code for actual BIDS registration also complexifies the importer quite a bit, and simplifying it would require a large (but desirable) refactor of the BIDS importer (specifically create a common factorization for all BIDS file imports), which is outside of the scope of this PR. Integration tests are nonetheless improved in this PR to ensure that everything works as expected and continues to do so in the future.BIDS importer design
BidsImportEnvtoBidsImporter.BidsImporteris the central object for BIDS import, which contains:Open design questions