Skip to content

[genomic_browser] Fix several issues including misaligned table columns, broken filters, and multilingual code - #11126

Open
HachemJ wants to merge 3 commits into
aces:29.0-releasefrom
HachemJ:FixDataEntriesAndFiltersTranslationsGenomicBrowser
Open

[genomic_browser] Fix several issues including misaligned table columns, broken filters, and multilingual code#11126
HachemJ wants to merge 3 commits into
aces:29.0-releasefrom
HachemJ:FixDataEntriesAndFiltersTranslationsGenomicBrowser

Conversation

@HachemJ

@HachemJ HachemJ commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Brief summary of changes

This PR fixes several issues in the genomic_browser module related to filtering, translations, and data presentation. It corrects column alignment issues that caused values to appear under incorrect headers, ensuring that the displayed data corresponds to the appropriate columns. It also fixes filtering for translated fields such as Sex, Cohorts and Strand by keeping filter values consistent with the underlying data while displaying translated labels to users. In addition, the PR adds missing translations for several genomic specific values and adds the remaining translations of option lists throughout the module.

It also removes an unused Date of Birth column from the frontend. The column does not appear in the backend JSON response at all, so it was effectively unused. Since the table data is constructed using json.data.map((e) => Object.values(e)), having an extra frontend only column shifted the column ordering and contributed to the alignment issues.

Testing instructions (if applicable)

  1. git checkout HachemJ/FixDataEntriesAndFiltersTranslationsGenomicBrowser
  2. delete project/locale
  3. copy raisinbread/locale into project/locale
  4. run make dev (make sure it ran the msgfmt --use-fuzzy -o table.mo table.po commands)
  5. Go to 'Genomics' -> 'Genomic Browser'

Link(s) to related issue(s)

…d table columns, broken filters, and some missing translations for genomic labels and option values.
@github-actions github-actions Bot added RaisinBread PR or issue introducing/requiring improvements to the Raidinbread dataset Language: PHP PR or issue that update PHP code Language: Javascript PR or issue that update Javascript code Module: genomic_browser PR or issue related to genomic_browser module Multilingual Any tasks related to making LORIS multilingual labels Jul 31, 2026
@HachemJ HachemJ added the 29.0.0 - Bugs Issues found during the release testing for 29.0.0 label Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

29.0.0 - Bugs Issues found during the release testing for 29.0.0 Language: Javascript PR or issue that update Javascript code Language: PHP PR or issue that update PHP code Module: genomic_browser PR or issue related to genomic_browser module Multilingual Any tasks related to making LORIS multilingual RaisinBread PR or issue introducing/requiring improvements to the Raidinbread dataset

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant