[genomic_browser] Fix several issues including misaligned table columns, broken filters, and multilingual code - #11126
Open
HachemJ wants to merge 3 commits into
Conversation
…d table columns, broken filters, and some missing translations for genomic labels and option values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This PR fixes several issues in the genomic_browser module related to filtering, translations, and data presentation. It corrects column alignment issues that caused values to appear under incorrect headers, ensuring that the displayed data corresponds to the appropriate columns. It also fixes filtering for translated fields such as Sex, Cohorts and Strand by keeping filter values consistent with the underlying data while displaying translated labels to users. In addition, the PR adds missing translations for several genomic specific values and adds the remaining translations of option lists throughout the module.
It also removes an unused Date of Birth column from the frontend. The column does not appear in the backend JSON response at all, so it was effectively unused. Since the table data is constructed using
json.data.map((e) => Object.values(e)), having an extra frontend only column shifted the column ordering and contributed to the alignment issues.Testing instructions (if applicable)
project/localeraisinbread/localeintoproject/localemake dev(make sure it ran the msgfmt --use-fuzzy -o table.mo table.po commands)Link(s) to related issue(s)