Repository navigation
Share play: the picture follows the rate ladder during a share (T38) - #113
Merged
Merged
Conversation
… (T38) The host\x27s net service now moves the stream along the ladder from the guest\x27s reports: a new rate goes to the running encoder, a new size or frame rate is a new epoch, a new encoder and a config for the guest. The frame ring has the size of the top rung so that the picture can go up as well as down. The controller gets the player\x27s height limit for share_quality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gap 1 of T38: the stream no longer keeps the frame ring's size for the whole share.
Startto the worker,configto the guest, key frame).RateController::set_max_height(the player's limit forshare_quality, wired in the next PR).Tests:
retuneunit tests (same target, rate only, shape change, epoch wrap, pause), controller tests for the height limit, and an in-process integration test incrates/net/tests/play.rs(heavy loss reported by the guest moves host and guest to 540p30 in a new epoch and whole pictures keep coming).Not proven: a real game's ring at 1080p, real encoders' reaction to a size change on real hardware.
Need help on this PR? Tag
@codesmith-botwith what you need.