Repository navigation
Fix the remaining macOS flakes: real-window clip and relay-loss tests - #127
Merged
Merged
Conversation
… relay-loss test the relay client's idle timeout
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #124.
real_window::the_worker_saves_a_clip_of_a_real_window(share-worker access.rs; 3 failures, allended: no_window). The test waited a fixed 3 s after Calculator's process appeared; on a cold start (this test runs first) the window is not listed by then, and the worker only looks for a few seconds. The test now pollssck::find_windowuntil the system lists the window (up to 60 s) before it starts the worker. What the test proves is unchanged. One failure (02:31 UTC) was on a head that already had #101, so #101 did not cover this.share_play.rs:103"ring cannot be created: File exists" (2 failures): no change. Both runs (01:40 and 01:44 UTC) predate #102 (02:04 UTC), which added the per-process counter toring_name; no failure since.tunnel.rs:451without_an_answer_to_the_probes_the_relay_still_makes_it_type_2(2 failures). Afterrelay.stop()the endpoint must notice the loss within 10 s. Measured on an idle Windows machine: 61-64 ms (the relay's close arrives). I could not reproduce the failure (the build laptop was unreachable, no macOS here), so the cause is inferred, not observed: when that close does not reach the endpoint, the endpoint only learns from its QUIC connection's idle timeout, 35 s in iroh-relay 1.4.1 (quic.rs). The bound is now 45 s, derived from that constant. The test still fails if the endpoint never notices. Unverified on macOS until CI runs it repeatedly.Need help on this PR? Tag
@codesmith-botwith what you need.