Specify AppLabel for SyncComponent / ExtractComponent / ExtractResource#24420
Open
Zeophlite wants to merge 10 commits into
Open
Specify AppLabel for SyncComponent / ExtractComponent / ExtractResource#24420Zeophlite wants to merge 10 commits into
AppLabel for SyncComponent / ExtractComponent / ExtractResource#24420Zeophlite wants to merge 10 commits into
Conversation
e299d0d to
5b5444c
Compare
AppLabel for SyncComponent / ExtractComponent / ExtractResource
5b5444c to
114148f
Compare
114148f to
3517862
Compare
kfc35
approved these changes
May 24, 2026
8314bbd to
d60f1c8
Compare
kfc35
approved these changes
May 25, 2026
Contributor
kfc35
left a comment
There was a problem hiding this comment.
Approving but trusting you’ll clean up some of the docs that might be outdated for the affected structs
Co-authored-by: Kevin Chen <chen.kevin.f@gmail.com>
7c47566 to
0f661c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
bevy_extracttracking #24483 )#[derive(ExtractComponent)](preferentially) , orimpl ExtractComponent for Foo {}(similarly forExtractResourceandSyncComponent) . To make extraction possible to different sub-apps, we need to mark all these as explicitly forRenderAppSolution
ExtractComponent,ExtractResourceandSyncComponentto specify theAppLabelthe trait is implemented for. The corresponding plugin is only implemented forRenderApp.impl, specifyRenderApp, e.g.impl ExtractComponent<RenderApp> for Foo {}ExtractComponentandExtractResource, specify theAppLabelwith the attribute#[extract_app(RenderApp)]Reviewer Notes
Wow 64 files changed! But it's really just 7 files, the rest is mechanical
derive(ExtractComponent)derive(ExtractResource)ExtractComponenttraitExtractResourcetraitSyncComponenttraitI suggest first reading the
ExtractResourcechanges as a starting pointTesting
cargo run --example animated_mesh