Document define_label! sufficiently that it can be used.#24444
Merged
Conversation
ChristopherBiscardi
approved these changes
May 25, 2026
kfc35
added
C-Docs
kfc35
approved these changes
May 26, 2026
kfc35
added
S-Ready-For-Final-Review
pull Bot
pushed a commit
to VitalyAnkh/bevy
that referenced
this pull request
Jun 2, 2026
…erner private. (bevyengine#24445) # Objective Simplify the use of `define_label!()`. ## Solution - Move the `static` interner inside the `intern()` method, so that it is not visible anywhere else and does not need to have a non-conflicting name. The only operation the interner has is interning, so the `intern()` trait method is all the access that is ever needed. - Also added support for trailing commas. This PR will conflict with bevyengine#24444. I will rebase whichever one doesn’t get merged first. ## Testing - Ran tests with `cargo run -p ci -- --keep-going test`. There were some failures that I believe are existing/spurious.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #22834.
Solution
define_label!doesextra_methods_implexample to forward the callThis PR will conflict with #24445. I will rebase whichever one doesn’t get merged first.
Testing