docs: explain morph weight limit#24459
Open
YUHAO-corn wants to merge 1 commit into
Open
Conversation
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide, as well as our policy regarding AI usage, and we look forward to reviewing your pull request shortly ✨ |
amtep
approved these changes
May 28, 2026
laundmo
added
C-Docs
laundmo
added
the
D-Trivial
laundmo
reviewed
May 29, 2026
Comment on lines
-16
to
-20
| /// This is used to allocate buffers. | ||
| /// The correctness of the value depends on the GPU/platform. | ||
| /// The current value is chosen because it is guaranteed to work everywhere. | ||
| /// To allow for bigger values, a check must be made for the limits | ||
| /// of the GPU at runtime, which would mean not using consts anymore. |
Member
There was a problem hiding this comment.
Seems odd to me to remove documentation here. Should probably be left or replaced with a doc-link to the MAX_MORPH_WEIGHTS
alice-i-cecile
added
the
S-Ready-For-Final-Review
alice-i-cecile
added
S-Waiting-on-Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Document why
MAX_MORPH_WEIGHTSis fixed at its current value, matching the existing explanation forMAX_JOINTS.Fixes #15974.
Solution
MAX_MORPH_WEIGHTSconstant.MORPH_BUFFER_SIZEdocumentation focused on the derived buffer size.Testing
rustfmt +1.93.0-aarch64-apple-darwin --check crates/bevy_mesh/src/morph.rs crates/bevy_pbr/src/render/mesh_bindings.rsgit diff --checkNote:
cargo +1.93.0-aarch64-apple-darwin check -p bevy_mesh -p bevy_pbrcould not run in this environment because crates.io DNS resolution failed while fetching the index.