Harden pull_request_target workflows against untrusted checkout#24461
Open
stuartparmenter wants to merge 1 commit into
Open
Harden pull_request_target workflows against untrusted checkout#24461stuartparmenter wants to merge 1 commit into
stuartparmenter wants to merge 1 commit into
Conversation
mockersf
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
I've been going through a lot of my github workflows lately to try and tighten them, and wanted to see if there were any obvious issues in the Bevy ones. They seem generally safe as-is, but can be hardened further to avoid future issues.
The action-on-PR-labeled.yml workflow runs on pull_request_target, which grants it write permissions on the repo with access to secrets. It was checking out the PR's head SHA (ref: ${{ github.event.pull_request.head.sha }}) and running git against it in order to detect whether the PR touched the migration-guides / release-notes directories.
Solution
Testing