Repository navigation
Conversation
12 of 13 tasks
Contributor
Author
|
Consolidated into #14079, which adds all of these guest_none_relocations invalid cases in one change so the test file has a single open pull request. Closing this per-case pull request in favour of that one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Guest modules with
PT_TLSp_memszabove0x7fff0000are refused on the Windows guest path (WindowsTlsBuilderemitsInvalid or unsupported ELF TLS layout). Linux guest conversion does not apply this cap, so the refusal is only observable with--windows. Adds oneinvalid_cases_windowsentry withp_memsz=0x80000000,p_align=8,p_filesz=0.Merge-order with the open
#13711–#13765guest_none_relocations family; distinct from macOS-only#13765.Tested
macOS arm64, upstream/main
18f5949788, Python 3.13, relinker-only Release.ctest -R guest_none_relocations: pass (invalid-tls-segment-large-memszsce False/True on--windows).ctest -j 8 -E vulkan_validation_gate: 526/526.check_conventions+pr_overlap: pass (merge-order only vs guest_none family).Checklist