Skip to content

test(relinker): pin invalid guest TLS large memsz on Windows - #13767

Closed
rooklz wants to merge 1 commit into
boykopovar:mainfrom
rooklz:test/invalid-guest-windows-tls-large-memsz
Closed

rooklz wants to merge 1 commit into
boykopovar:mainfrom
rooklz:test/invalid-guest-windows-tls-large-memsz

Conversation

@rooklz

@rooklz rooklz commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

What

Guest modules with PT_TLS p_memsz above 0x7fff0000 are refused on the Windows guest path (WindowsTlsBuilder emits Invalid or unsupported ELF TLS layout). Linux guest conversion does not apply this cap, so the refusal is only observable with --windows. Adds one invalid_cases_windows entry with p_memsz=0x80000000, p_align=8, p_filesz=0.

Merge-order with the open #13711–#13765 guest_none_relocations family; distinct from macOS-only #13765.

Tested

macOS arm64, upstream/main 18f5949788, Python 3.13, relinker-only Release.

  • ctest -R guest_none_relocations: pass (invalid-tls-segment-large-memsz sce False/True on --windows).
  • ctest -j 8 -E vulkan_validation_gate: 526/526.
  • check_conventions + pr_overlap: pass (merge-order only vs guest_none family).

Checklist

  • AI-assisted: yes

@rooklz

rooklz commented Oct 31, 2026

Copy link
Copy Markdown
Contributor Author

Consolidated into #14079, which adds all of these guest_none_relocations invalid cases in one change so the test file has a single open pull request. Closing this per-case pull request in favour of that one.

@rooklz rooklz closed this Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant