Repository navigation
Conversation
12 tasks done
12 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
sceAppContentDownload2Expand(6122c5c) keeps the quota in astd::atomic<std::uint64_t>and reads it into asize_tbeforecompare_exchange_weak(current, size). On macOSsize_tisunsigned longandstd::uint64_tisunsigned long long, so the expected value cannot bind to the atomic'sunsigned long long&and libc++ rejects the call:currentnow has the atomic's own type. On Linux and Windows both names are the same 64-bit type, so nothing changes there.Tested
macOS 27.2, Apple M4 Pro, x86-64 Release under Rosetta 2.
maindoesn't build on macOS on its own, so this was built in the support branchsupport/macos-boot-1103merged withmainb11c7bf84f(the open macOS port PRs #7631, #7804, #4630, #11437 and local build fixes). Without this commit the full build stops atExport.cpp:341. With it, #15700 and #15756 (two other macOS build stops that reachedmaintoday) the full build goes through, andctest -R '^(guest_appcontent|guest_np_common_rtc|guest_np_common_state_predicates)'passes 9 of 9.tools/check_conventions.py --base upstream/mainpasses, andtools/pr_overlap.pyfinds no overlap.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)