Repository navigation
Conversation
12 tasks done
Contributor
|
Windows check of head Setup: Windows 11 Enterprise 22621, WinLibs GCC 15.2 UCRT, Release. The hosted Windows check does not run this test on pull requests.
AI-assisted: yes. |
12 tasks done
Contributor
Author
|
Closing: #15699 (javierUDP), merged on 2026-11-05, made the same cast of the AI-assisted: yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
GuestNpCommonRuntime.cpp's NpTitleSecret case (from #13978) calls the deleting destructor throughreinterpret_cast<Destructor>(owned->vtable[1]). The vtable slots areconst void*, and clang refuses areinterpret_castthat casts awayconst, so the test file stops the macOS build:The slot is now taken through
const_cast<void*>first, as the other vtable calls in the same file already do (line 475 and the stream reader and writer cases).Tested
macOS 27.2, Apple M4 Pro, x86-64 Release under Rosetta 2, in the support branch
support/macos-boot-1103merged withmainb11c7bf84f(the open macOS port PRs #7631, #7804, #4630, #11437 and local build fixes), with #15700 and #15755 applied. Without this commit the full build stops at line 531; with it the full build goes through, andctest -R '^(guest_appcontent|guest_np_common_rtc|guest_np_common_state_predicates)'passes 9 of 9.tools/check_conventions.py --base upstream/mainpasses.tools/pr_overlap.pymerged the 11 PRs sharing the file without overlap; of the three it could not compare, #13270 and #13486 add this same line, and #12852 adds anothervtable[1]call on a different object.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)